Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): add minimum supported Node versions #621

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

lanesawyer
Copy link
Contributor

chore(config): Add minimum supported Node versions

Resolves #602 by adding engines to npm package for the minimum supported versions of Node and adds those to the website page about npm

Motivation and Context

Makes system dependencies clearer.

How Has This Been Tested?

Followed the process I documented on this comment to find the versions that worked

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lanesawyer lanesawyer requested a review from orhun as a code owner April 23, 2024 02:19
Copy link

welcome bot commented Apr 23, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.90%. Comparing base (68b9839) to head (1f0d14a).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   41.90%   41.90%           
=======================================
  Files          15       15           
  Lines        1079     1079           
=======================================
  Hits          452      452           
  Misses        627      627           
Flag Coverage Δ
unit-tests 41.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@orhun orhun changed the title chore(config): Add minimum supported Node versions chore(npm): add minimum supported Node versions Apr 23, 2024
@orhun orhun merged commit 95bdf2d into orhun:main Apr 23, 2024
44 checks passed
Copy link

welcome bot commented Apr 23, 2024

Congrats on merging your first pull request! ⛰️

@lanesawyer lanesawyer deleted the minimum-supported-node branch April 23, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.x series fails to work in NPM scripts
3 participants