[material-ui][Divider] borderStyle enhancement in divider with children #42715
Conversation
| @@ -137,6 +137,8 @@ const DividerRoot = styled('div', { | |||
| whiteSpace: 'nowrap', | |||
| textAlign: 'center', | |||
| border: 0, | |||
| borderTopStyle: 'solid', | |||
There was a problem hiding this comment.
this change sets the default border style, that can be inherited by before and after pseudo-elements.
There was a problem hiding this comment.
What happens if we remove these? Isn't line 61 above enough to set the default to be inherited?
There was a problem hiding this comment.
In our case (divider with children), the border-style is being inherited from Line 139, not from Line 61. Line 139, border : 0 sets the border-style to none, which will remove the border. Hence, the need to explicitly add border styling.
Netlify deploy previewhttps://deploy-preview-42715--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Thanks for working on this @anuujj! I left a question.
The solution is working as expected: https://codesandbox.io/p/sandbox/pr-42715-1-pyqg9y
fixes #42569