Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto request review workflow #44332

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Auto request review workflow #44332

wants to merge 13 commits into from

Conversation

qnkhuat
Copy link
Contributor

@qnkhuat qnkhuat commented Jun 18, 2024

Add a workflow that will request review based on file changes.
This works independently with CODEOWNERS.

I added myself and Cal to be added as reviewers for the migrations file as an example.

Note: we can also request team (e.g: core-backend-components) but it needs some more configuration, I'll make it work once we decide this is something we want.


But how is it different from CODEOWNERS?
With codeowners, it requests reviewers for the most specific pattern. An example:

  • if Cam is the codeowner of src/**
  • Ngoc is the codeowner of src/metabase/pulse/**

Then if there are changes to src/metabase/pulse/core.clj then only Ngoc is added as reviewer. Cam is excluded. But in some cases, we want both Ngoc and Cam to be added.

Read more here

@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label Jun 18, 2024
@qnkhuat qnkhuat requested a review from camsaul as a code owner June 18, 2024 04:37
@github-actions github-actions bot requested a review from piranha June 18, 2024 04:39
@qnkhuat qnkhuat removed the request for review from piranha June 18, 2024 04:40
@github-actions github-actions bot requested a review from calherries June 18, 2024 04:43
@qnkhuat qnkhuat removed the request for review from calherries June 18, 2024 04:43
@qnkhuat qnkhuat changed the title Add Auto request review workflow Auto request review workflow Jun 18, 2024
@qnkhuat qnkhuat added the backport Automatically create PR on current release branch on merge label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/BackendComponents also known as BEC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant