Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): update icons on links example #34279

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(css): update icons on links example #34279

merged 1 commit into from
Jun 20, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jun 20, 2024 •
edited by Josh-Cena
Loading

The PR uses ::after, removes unrelated css rules, updates pros, and duplicate note (the note has been mentioned already at the top of the page).

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner June 20, 2024 07:52
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team June 20, 2024 07:52
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/s [PR only] 6-50 LoC changed labels Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

External URLs (1)

URL: /en-US/docs/Learn/CSS/Styling_text/Styling_links
Title: Styling links

hamishwillee
hamishwillee approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks very much

@hamishwillee hamishwillee merged commit 68da45a into mdn:main Jun 20, 2024
7 checks passed
@OnkarRuikar OnkarRuikar deleted the css_link_icons branch June 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:Learn:CSS Learning area CSS docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ::after to including icons on links
2 participants
@OnkarRuikar @hamishwillee