Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change incorrect href #34198

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Change incorrect href #34198

merged 2 commits into from
Jun 17, 2024

Conversation

dragunovartem99
Copy link
Contributor

@dragunovartem99 dragunovartem99 commented Jun 16, 2024

Right now link for common attribute "form" points to incorrect page (Element/Form).

It expected to be linked with input page, and #form section inside it, that is describing this attribute.

For now, auto-scrolling to section doesn't work in for some reason for Chrome (Version 125.0.6422.60)

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#form

But I believe commited link is correct

Description

Motivation

Additional details

Related issues and pull requests

Right now link for common attribute "form" points to incorrect page (Element/Form).

It expected to be linked with input page, and #form section inside it.

For now, auto-scrolling to section doesn't work in Firefox for some reason for https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#form

But I believe commited link is correct
@dragunovartem99 dragunovartem99 requested a review from a team as a code owner June 16, 2024 09:17
@dragunovartem99 dragunovartem99 requested review from hamishwillee and removed request for a team June 16, 2024 09:17
@github-actions github-actions bot added Content:Learn:Forms Learning area Forms docs size/xs 0-5 LoC changed labels Jun 16, 2024
Copy link
Contributor

github-actions bot commented Jun 17, 2024

Preview URLs

(comment last updated: 2024-06-17 01:37:47)

@github-actions github-actions bot added size/s 6-50 LoC changed and removed size/xs 0-5 LoC changed labels Jun 17, 2024
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks - don't know why the scrolling doesn't work properly, but it isn't a problem with this PR.

@hamishwillee hamishwillee merged commit 0b32cd9 into mdn:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Forms Learning area Forms docs size/s 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants