Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements on glossary Apple Safari #34100

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

PassionPenguin
Copy link
Contributor

Description

  • it's now supported on visionOS
  • more detailed information
  • linked with glossary WebKit

@PassionPenguin PassionPenguin requested a review from a team as a code owner June 13, 2024 05:18
@PassionPenguin PassionPenguin requested review from dipikabh and removed request for a team June 13, 2024 05:18
@github-actions github-actions bot added Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels Jun 13, 2024
Copy link
Contributor

github-actions bot commented Jun 13, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Glossary/Apple_Safari
Title: Apple Safari

(comment last updated: 2024-06-17 12:50:12)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PassionPenguin. I've added a few suggestions.

files/en-us/glossary/apple_safari/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/apple_safari/index.md Outdated Show resolved Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
[**Safari**](https://www.apple.com/safari/) is a {{Glossary("Browser","Web browser")}} developed by Apple and bundled with macOS, iPadOS, and iOS. It's based on the open-source [WebKit](https://webkit.org/) engine.
[**Safari**](https://www.apple.com/safari/) is a {{Glossary("Browser","web browser")}} developed by Apple and is built into Apple's operating systems, including macOS (for Mac computers), iPadOS (for iPad tablets), iOS (for iPhones), and visionOS (for augmented reality devices like the Apple Vision Pro).

Safari was first introduced in 2003 on Mac OS X Panther and later on iOS in 2007, using the open source {{glossary("WebKit")}} engine, which was derived from [KHTML](https://en.wikipedia.org/wiki/KHTML). Apple used to offer a version of Safari for Windows, but it was discontinued in 2012.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information is unnecessary for defining Safari and doesn't help readers understand what Safari is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't rendering engine been related to what a browser is? Given readers on site care about the implementation of different features supported by engines themselves

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but the history is irrelevant for a glossary entry and is more suitable for a Wikipedia-style article. The first paragraph is good enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, let's remove this info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, seems to have removed far more information than history itself. now the page contains nothing but OS it supports.

@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jun 17, 2024
@dipikabh dipikabh merged commit a71a1d5 into mdn:main Jun 17, 2024
8 checks passed
@PassionPenguin PassionPenguin deleted the safari branch June 18, 2024 01:06
PassionPenguin added a commit to PassionPenguin/content that referenced this pull request Jun 18, 2024
bsmth added a commit that referenced this pull request Jun 25, 2024
fixes #34100

Co-authored-by: Brian Thomas Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants