Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improvements on glossary screen reader #34097

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat: improvements on glossary screen reader #34097

merged 2 commits into from
Jun 18, 2024

Conversation

PassionPenguin
Copy link
Contributor

Description

  • added ChromeVox, Narrator description.
  • links improvements

@PassionPenguin PassionPenguin requested a review from a team as a code owner June 13, 2024 03:28
@PassionPenguin PassionPenguin requested review from dipikabh and removed request for a team June 13, 2024 03:28
@github-actions github-actions bot added Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2024 •
edited
Loading

Preview URLs

External URLs (5)

URL: /en-US/docs/Glossary/Screen_reader
Title: Screen reader

(comment last updated: 2024-06-13 04:40:59)

estelle
estelle reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to get rid of voice over instructions, especially if we keep the instructions on how to turn it on. Any thoughts on where we could put the instructions? or a link to the instructions for all of them?

files/en-us/glossary/screen_reader/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/screen_reader/index.md Outdated Show resolved Hide resolved
@PassionPenguin
Copy link
Contributor Author

I'm hesitant to get rid of voice over instructions, especially if we keep the instructions on how to turn it on. Any thoughts on where we could put the instructions? or a link to the instructions for all of them?

u're right. let's add a link to VoiceOver general commands on Mac

@PassionPenguin @estelle
feat: improvements
f2746b3 
Co-authored-by: Estelle Weyl <[email protected]>
@dipikabh dipikabh removed their request for review June 13, 2024 12:21
@estelle estelle merged commit 44037e8 into mdn:main Jun 18, 2024
8 checks passed
@yin1999 yin1999 mentioned this pull request Jun 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PassionPenguin @estelle