Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

::backdrop is well supported #34076

Merged
merged 7 commits into from
Jun 13, 2024
Merged

::backdrop is well supported #34076

merged 7 commits into from
Jun 13, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 12, 2024 •
edited

the previous example was a screen shot. fixes #33957

@estelle
::backdrop is well supported
416a908 
the previous example was a screen shot.
@estelle estelle requested a review from a team as a code owner June 12, 2024 07:55
@estelle estelle requested review from dipikabh and removed request for a team June 12, 2024 07:55
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m 51-500 LoC changed labels Jun 12, 2024
@estelle @github-actions
Apply suggestions from code review
9021e6a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited

Preview URLs

(comment last updated: 2024-06-13 00:49:29)

@estelle estelle mentioned this pull request Jun 12, 2024
Closed
wbamberg
wbamberg reviewed Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, but while I think this is overall a good change I don't think it fixes #33957, does it? It seems unrelated to the person's issue.

files/en-us/web/css/_doublecolon_backdrop/index.md Outdated Show resolved Hide resolved
wbamberg
wbamberg approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@wbamberg wbamberg merged commit 7dae0a0 into main Jun 13, 2024
9 checks passed
@wbamberg wbamberg deleted the estelle-patch-8 branch June 13, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@wbamberg wbamberg wbamberg approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML Demo for ::backdrop pseudo-element has invisible button
2 participants
@estelle @wbamberg