Intl.Locale.getWeekInfo() fixes #33976
Conversation
|
Preview URLs External URLs (1)URL:
|
|
Thank you @Josh-Cena Lookds great ! |
| const msBN = new Intl.Locale("ms-BN"); | ||
| console.log(msBN.getWeekInfo()); // { firstDay: 7, weekend: [5, 7], minimalDays: 1 } | ||
| // Brunei weekend is Friday and Sunday but not Saturday | ||
| const arAF = new Intl.Locale("ar-AF"); // Arabic (Afghanistan) | ||
| console.log(arAF.getWeekInfo()); // { firstDay: 6, weekend: [4, 5], minimalDays: 1 } |
There was a problem hiding this comment.
I'm not sure why you'd omit an example where the weekend is not contiguous. That in combination with the note above seems to encourage people to ignore places where the weekend is split up. If you're going to use this API at all you might as well use it as intended
There was a problem hiding this comment.
I see the other issue now, the underlying CLDR dataset is wrong. I think in this case there should be clarification and an issue filed in the cldr repo as the weekend in Brunei is on Friday and Sunday.
There was a problem hiding this comment.
I see the other issue now, the underlying CLDR dataset is wrong. I think in this case there should be clarification and an issue filed in the cldr repo as the weekend in Brunei is on Friday and Sunday.
You can report an issue to the Unicode CLDR here: https://cldr.unicode.org/
There was a problem hiding this comment.
Relevant issue: https://unicode-org.atlassian.net/browse/CLDR-14903
There was a problem hiding this comment.
Yeah, thanks for the link. Until the bug is fixed (and browsers ship it) we can keep the examples in this form.
cc @jackdeguest @jamiebuilds in case you are interested in taking a look