Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33238: step is not always 1 #33928

Merged
merged 3 commits into from
Jun 7, 2024
Merged

33238: step is not always 1 #33928

merged 3 commits into from
Jun 7, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 4, 2024

fixes #33238

@estelle estelle requested a review from a team as a code owner June 4, 2024 23:38
@estelle estelle requested review from dipikabh and removed request for a team June 4, 2024 23:38
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Jun 4, 2024
@estelle estelle mentioned this pull request Jun 4, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-06-05 04:59:55)

dipikabh
dipikabh requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @estelle. I believe the entry in the "Default values for step" table for "datetime-local" also needs to be updated as pointed in the issue.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jun 5, 2024
@estelle
Copy link
Member Author

estelle commented Jun 5, 2024 •
edited
Loading

Thanks for these updates, @estelle. I believe the entry in the "Default values for step" table for "datetime-local" also needs to be updated as pointed in the issue.

Good call @dipikabh. Oddly, it was correct on https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local but not here.

@estelle estelle requested a review from dipikabh June 5, 2024 04:59
dipikabh
dipikabh approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@dipikabh dipikabh merged commit 4ebcf6b into main Jun 7, 2024
9 checks passed
@dipikabh dipikabh deleted the estelle-patch-16 branch June 7, 2024 04:20
@estelle
Copy link
Member Author

estelle commented Jun 7, 2024

where are you or what's going on that you are reviewing PRs at 2:00am or so Toronto time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default step value for datetime-local input is incorrect
2 participants
@estelle @dipikabh