Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time input: remove fallbacks #33924

Merged
merged 6 commits into from
Jun 6, 2024
Merged

time input: remove fallbacks #33924

merged 6 commits into from
Jun 6, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 4, 2024

No description provided.

@estelle estelle requested a review from a team as a code owner June 4, 2024 21:53
@estelle estelle requested review from chrisdavidmills and removed request for a team June 4, 2024 21:53
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/m 51-500 LoC changed labels Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Preview URLs

(comment last updated: 2024-06-06 07:55:21)

estelle and others added 2 commits June 4, 2024 14:55
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for you, nothing major.

files/en-us/web/html/element/input/time/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/time/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/time/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/time/index.md Outdated Show resolved Hide resolved
@estelle
Copy link
Member Author

estelle commented Jun 5, 2024

@chrisdavidmills committed all your suggestions. Thanks for the review

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! LGTM.

@chrisdavidmills chrisdavidmills merged commit cd02f87 into main Jun 6, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the estelle-patch-13-1 branch June 6, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/m 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants