Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Observatory docs to MDN #33793
base: main
Are you sure you want to change the base?
Add Observatory docs to MDN #33793
Changes from 1 commit
4703db1
c04092c
5254100
c39da2b
c7a383a
3164d32
06d0b98
cc8a1bb
d7d47c7
64dd386
0dc7334
883d4a5
68659ec
8c03637
189313e
460025c
ec81406
74ab66d
dbeb415
0d277b9
d01abc7
63410ca
612279a
1d6810d
e24c1a2
65a6c43
a307fc4
309e549
7755192
a9d6f30
7b437a9
d7a2d24
5b4e224
69de9a9
85916b3
536fc91
46e7951
c43f8ea
8d68d09
cfa0529
b19f5e2
8ded9c2
d828218
93eca1a
35c1c3b
6da1616
66f47fe
74eae48
d7375f5
006f2f7
e18b08f
26e178a
796d616
75dd4d9
72d7c97
0529929
2875f75
02051b8
2e5a8ee
bfda732
f7c14a7
a692710
0a76c93
762d53f
3aa78fd
abc565f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first "Guide" column also needs to be made consistent in verbiage because some entries are noun phrases ("TLS configuration") and some indicate activity ("Verifying"). WDYT about:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable. I've mostly used these, with a couple of tweaks. I also tried updating them on the page titles too, for consistency.
This does mean that way more titles now break onto two lines in the sidebar and pages themselves.
Do you think that is a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be checked later after updated preview links are available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is to use only the acronym in the sidebar (short-title) and the expanded title on the page, so:
One of the things this can help with is that when you're on the landing page, you can quickly match up the guides from the table's first column to those in the sidebar. At the moment, you need to parse the titles in the sidebar a bit.
With both the expanded form and acronym in the page title, the page will still be searchable in the "Quick Search" field using either the long form or acronym.
But I'll leave it to you to make the call. The glossary pages have acronyms in the sidebar - I don't know if we have a strict guideline or any guideline around this.