Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in Glossary/Gzip_compression #33753

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

PassionPenguin
Copy link
Contributor

@PassionPenguin PassionPenguin commented May 25, 2024

Details

Modifications

  1. GZip => gzip, as gzip has no capitalization like GZip in anywhere else than mdn... (and a question in stackoverflow)

(mdn/translated-content#20572 (comment))

@PassionPenguin PassionPenguin requested a review from a team as a code owner May 25, 2024 14:35
@PassionPenguin PassionPenguin requested review from chrisdavidmills and removed request for a team May 25, 2024 14:35
@github-actions github-actions bot added Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels May 25, 2024
Copy link
Contributor

github-actions bot commented May 25, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Glossary/gzip_compression
Title: gzip compression

(comment last updated: 2024-05-29 05:01:41)

@hamishwillee
Copy link
Collaborator

hamishwillee commented May 26, 2024

Thanks @PassionPenguin

Really you should never directly touch the redirects file. The way to do this is using Yari, and following the instruction here: https://github.com/mdn/content/blob/main/CONTRIBUTING.md#moving-documents

I would undo any change that touch this file and then use yari. It is way safer.

@PassionPenguin
Copy link
Contributor Author

Thanks @PassionPenguin

Really you should never directly touch the redirects file. The way to do this is using Yari, and following the instruction here: https://github.com/mdn/content/blob/main/CONTRIBUTING.md#moving-documents

I would undo any change that touch this file and then use yari. It is way safer.

u r right! please make the necessary changes to makes yari happy :)

@hamishwillee
Copy link
Collaborator

I have stripped out the redirect changes.

@OnkarRuikar Do you know anything about yari move? I'm running yarn content move Glossary/GZip_compression Glossary/Gzip_compression and while the tool says it is doing something, there are no file changes. I have tried this in both Linux and Windows.

I think that probably Yari doesn't care - it ignores the case sensitivity. But want to make sure before we merge this.

@chrisdavidmills chrisdavidmills removed their request for review May 27, 2024 09:33
@OnkarRuikar
Copy link
Contributor

@OnkarRuikar Do you know anything about yari move? I'm running yarn content move Glossary/GZip_compression Glossary/Gzip_compression and while the tool says it is doing something, there are no file changes. I have tried this in both Linux and Windows.

I think that probably Yari doesn't care - it ignores the case sensitivity. But want to make sure before we merge this.

Sorry for the late response. It doesn't work when you update document slug manually then run yarn content move .... When I started from fresh and ran yarn content move Glossary/GZip_compression Glossary/gzip_compression it did update _redirectss.txt, _wikihistory.json, and gzip_compression/index.md files.

Is it gzip or Gzip?

At this juncture I suggest @PassionPenguin (or whoever has write access to the branch) to run following commands to get this PR on the track:

git reset --soft HEAD~1
git stash save

yarn content move Glossary/GZip_compression Glossary/gzip_compression
git commit -am "fix: typo"

git stash pop
git commit -am "file changes"
git push --force

@PassionPenguin
Copy link
Contributor Author

PassionPenguin commented May 29, 2024

so that's the necessary changes :)

(following that commands above)

@OnkarRuikar
Copy link
Contributor

OnkarRuikar commented May 29, 2024

yarn content move ... updates files/en-us/_wikihistory.json file as well. Please commit it as well if you've missed it. It is auto generated/updated stuff. Simply rerun the commands above to get it back in the PR.

@PassionPenguin
Copy link
Contributor Author

PassionPenguin commented May 29, 2024

@OnkarRuikar is it OK (or...normal?) to have these many changes in wikihistory? (performed a reset to upstream/main and yarn content move)

image

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels May 29, 2024
@OnkarRuikar
Copy link
Contributor

@OnkarRuikar is it correct to have these many changes in wikihistory? (performed a reset to upstream/main and yarn content)

The current changes look good. Don't worry about the other stuff in the json file. It simply got alphabetically sorted. Looks like something in the tool chain suddenly started sorting JSON string content.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PassionPenguin et al.

@hamishwillee hamishwillee merged commit cde6b82 into mdn:main May 31, 2024
9 checks passed
@PassionPenguin PassionPenguin deleted the patch-5 branch May 31, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants