-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in Glossary/Gzip_compression #33753
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2024-05-29 05:01:41) |
Thanks @PassionPenguin Really you should never directly touch the redirects file. The way to do this is using Yari, and following the instruction here: https://github.com/mdn/content/blob/main/CONTRIBUTING.md#moving-documents I would undo any change that touch this file and then use yari. It is way safer. |
u r right! please make the necessary changes to makes yari happy :) |
I have stripped out the redirect changes. @OnkarRuikar Do you know anything about I think that probably Yari doesn't care - it ignores the case sensitivity. But want to make sure before we merge this. |
Sorry for the late response. It doesn't work when you update document slug manually then run Is it At this juncture I suggest @PassionPenguin (or whoever has write access to the branch) to run following commands to get this PR on the track: git reset --soft HEAD~1
git stash save
yarn content move Glossary/GZip_compression Glossary/gzip_compression
git commit -am "fix: typo"
git stash pop
git commit -am "file changes"
git push --force |
so that's the necessary changes :) (following that commands above) |
|
@OnkarRuikar is it OK (or...normal?) to have these many changes in wikihistory? (performed a reset to ![]() |
The current changes look good. Don't worry about the other stuff in the json file. It simply got alphabetically sorted. Looks like something in the tool chain suddenly started sorting JSON string content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PassionPenguin et al.
Details
Modifications
GZip
in anywhere else than mdn... (and a question in stackoverflow)(mdn/translated-content#20572 (comment))