Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial review: CSS anchor positioning 5: position try functionality #33609

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Editorial review: CSS anchor positioning 5: position try functionality #33609

wants to merge 36 commits into from

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented May 14, 2024 •
edited

Description

CSS Anchor Positioning is set to be released in Chrome 125 (see the associated Chrome Status entry).

This PR (part of a series; see the first PR here) adds the following content:

  • The position-try-options property
  • The inset-area() function (only needs to be a short stub page)
  • The position-try-order property
  • The position-try shorthand property
  • The @position-try at-rule
  • The CSSPositionTryRule CSSOM interface and its properties:
    • name
    • style
  • The CSSPositionTryDescriptors CSSOM interface.

Do not merge until #33058 is merged.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner May 14, 2024 14:40
@chrisdavidmills chrisdavidmills requested review from estelle and removed request for a team May 14, 2024 14:40
@chrisdavidmills chrisdavidmills marked this pull request as draft May 14, 2024 14:40
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 14, 2024
@chrisdavidmills chrisdavidmills removed the request for review from estelle May 14, 2024 14:40
@github-actions github-actions bot added the size/m 51-500 LoC changed label May 14, 2024
@chrisdavidmills chrisdavidmills mentioned this pull request May 14, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Preview URLs (10 pages)
Flaws (69)

URL: /en-US/docs/Web/API/CSSPositionTryRule
Title: CSSPositionTryRule
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding

URL: /en-US/docs/Web/API/CSSPositionTryRule/name
Title: CSSPositionTryRule: name property
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding

URL: /en-US/docs/Web/API/CSSPositionTryRule/style
Title: CSSPositionTryRule: style property
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding

URL: /en-US/docs/Web/API/CSSPositionTryDescriptors
Title: CSSPositionTryDescriptors
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/inset-area does not exist
    • /en-US/docs/Web/CSS/position-anchor does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding

URL: /en-US/docs/Web/API/CSS_Object_Model
Title: CSS Object Model (CSSOM)
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/CSSFontFeatureValuesMap does not exist
    • /en-US/docs/Web/API/CSSMarginRule does not exist

URL: /en-US/docs/Web/CSS/inset-area_function
Title: inset-area()
Flaw count: 9

  • macros:
    • /en-US/docs/Web/CSS/inset-area does not exist
    • /en-US/docs/Web/CSS/inset-area does not exist
    • /en-US/docs/Web/CSS/inset-area does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • Can't resolve /en-US/docs/Web/CSS/inset-area_value
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • and 1 more flaws omitted

URL: /en-US/docs/Web/CSS/@position-try
Title: @position-try
Flaw count: 21

  • macros:
    • /en-US/docs/Web/CSS/position-anchor does not exist
    • /en-US/docs/Web/CSS/anchor-name does not exist
    • /en-US/docs/Web/CSS/inset-area does not exist
    • /en-US/docs/Web/CSS/anchor-name does not exist
    • /en-US/docs/Web/CSS/inset-area does not exist
    • and 8 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding
    • Can't resolve /en-US/docs/Web/CSS/anchor
    • Can't resolve /en-US/docs/Web/CSS/anchor-size
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using#centering_on_the_anchor_using_anchor-center
    • and 3 more flaws omitted

URL: /en-US/docs/Web/CSS/position-try-options
Title: position-try-options
Flaw count: 11

  • macros:
    • /en-US/docs/Web/CSS/inset-area does not exist
    • /en-US/docs/Web/CSS/position-visibility does not exist
    • /en-US/docs/Web/CSS/anchor-name does not exist
    • /en-US/docs/Web/CSS/position-anchor does not exist
    • /en-US/docs/Web/CSS/inset-area does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding
    • Can't resolve /en-US/docs/Web/CSS/inset-area_value
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • and 1 more flaws omitted

URL: /en-US/docs/Web/CSS/position-try
Title: position-try
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/anchor-name does not exist
    • /en-US/docs/Web/CSS/inset-area does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/inset-area_value
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding

URL: /en-US/docs/Web/CSS/position-try-order
Title: position-try-order
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/anchor-name does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Try_options_hiding

(comment last updated: 2024-06-14 10:43:26)

@github-actions github-actions bot added size/l 501-1000 LoC changed and removed size/m 51-500 LoC changed labels May 15, 2024
@github-actions github-actions bot added Content:WebAPI Web API docs size/xl >1000 LoC changed and removed size/l 501-1000 LoC changed labels May 16, 2024
@chrisdavidmills chrisdavidmills marked this pull request as ready for review May 16, 2024 09:33
@chrisdavidmills chrisdavidmills requested a review from a team as a code owner May 16, 2024 09:33
@chrisdavidmills chrisdavidmills requested review from wbamberg and removed request for a team and wbamberg May 16, 2024 09:33
mfreed7
mfreed7 reviewed May 17, 2024
View reviewed changes
Copy link

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

files/en-us/web/css/inset-area_function/index.md Show resolved Hide resolved
files/en-us/web/css/position-try-order/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/position-try-order/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/position-try-order/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/position-try-order/index.md Show resolved Hide resolved
files/en-us/web/css/position-try-options/index.md Show resolved Hide resolved
chrisdavidmills and others added 7 commits May 28, 2024 10:24
@chrisdavidmills @github-actions
Update files/en-us/web/api/csspositiontrydescriptors/index.md
358717d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills @github-actions
Update files/en-us/web/api/csspositiontrydescriptors/index.md
7feac15 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills @github-actions
Update files/en-us/web/api/csspositiontrydescriptors/index.md
b1b48fd 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills @github-actions
Update files/en-us/web/api/csspositiontrydescriptors/index.md
9a7159d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills @github-actions
Update files/en-us/web/css/@position-try/index.md
9bb621e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills @github-actions
Update files/en-us/web/api/csspositiontrydescriptors/index.md
b4aa225 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills
Run prettier to fix linter errors
621a4a4
@chrisdavidmills
Copy link
Contributor Author

@estelle thanks a lot for your work on this. I've answered your comments so far.

@estelle estelle mentioned this pull request Jun 1, 2024
Merged
estelle and others added 2 commits June 3, 2024 19:05
@estelle
remove tick marks
7b3c65d
@estelle @github-actions
Apply suggestions from code review
831334d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle

This comment was marked as resolved.

Sign in to view

chrisdavidmills and others added 2 commits June 5, 2024 12:28
@chrisdavidmills @github-actions
Update files/en-us/web/css/position-try-order/index.md
b86c777 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills
update @position-try example to include inset options
3642808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfreed7 mfreed7 mfreed7 left review comments

@github-actions github-actions[bot] github-actions left review comments

@estelle estelle Awaiting requested review from estelle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/xl >1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisdavidmills @estelle @mfreed7