Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: some improvements on glossary BiDi #33421

Merged
merged 6 commits into from
May 21, 2024
Merged

feat: some improvements on glossary BiDi #33421

merged 6 commits into from
May 21, 2024

Conversation

PassionPenguin
Copy link
Contributor

Description

Modification

  • the definition of the term. according to what the word bidirectional means, and the only macro referring to this glossary (i.e. bidi-ordering), this should be the property (characteristic) of a text, not the text itself.

Addition

  • example of a BiDi text
  • unicode's support of BiDi text

@PassionPenguin PassionPenguin requested a review from a team as a code owner May 5, 2024 13:09
@PassionPenguin PassionPenguin requested review from chrisdavidmills and removed request for a team May 5, 2024 13:09
@github-actions github-actions bot added Content:Glossary Glossary entries size/s 6-50 LoC changed labels May 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2024 •
edited

Preview URLs

External URLs (1)

URL: /en-US/docs/Glossary/BiDi
Title: BiDi

(comment last updated: 2024-05-09 08:01:48)

chrisdavidmills
chrisdavidmills requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PassionPenguin lovely, this is much better, and I thought the example really helped.

I just had a few language suggestions for you.

files/en-us/glossary/bidi/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/bidi/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/bidi/index.md Outdated Show resolved Hide resolved
chrisdavidmills
chrisdavidmills requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PassionPenguin oop, one more thing I noticed.

files/en-us/glossary/bidi/index.md Outdated Show resolved Hide resolved
PassionPenguin and others added 4 commits May 9, 2024 15:59
@PassionPenguin @chrisdavidmills
Update index.md
bc42d51 
Co-authored-by: Chris Mills <[email protected]>
@PassionPenguin @chrisdavidmills
Update index.md
03342f9 
Co-authored-by: Chris Mills <[email protected]>
@PassionPenguin @chrisdavidmills
Update index.md
7eb01ac 
Co-authored-by: Chris Mills <[email protected]>
@PassionPenguin
Update index.md
8a69942
@jasonren0403 jasonren0403 mentioned this pull request May 10, 2024
Merged
chrisdavidmills
chrisdavidmills approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for your hard work on this @PassionPenguin, and apologies for the delay in merging it.

@chrisdavidmills chrisdavidmills merged commit 742c3e7 into mdn:main May 21, 2024
8 checks passed
@PassionPenguin PassionPenguin deleted the bidi branch May 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:Glossary Glossary entries size/s 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PassionPenguin @chrisdavidmills