Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements on glossary Color Space #33407

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

PassionPenguin
Copy link
Contributor

Description

some improvements on the article to make it more fluent and consistent

Motivation

we have different typos of same word in this article

Additional details

Related issues and pull requests

@PassionPenguin PassionPenguin requested a review from a team as a code owner May 4, 2024 08:22
@PassionPenguin PassionPenguin requested review from hamishwillee and removed request for a team May 4, 2024 08:22
@github-actions github-actions bot added Content:Glossary Glossary entries size/s 6-50 LoC changed labels May 4, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

Preview URLs

External URLs (4)

URL: /en-US/docs/Glossary/Color_space
Title: Color space

(comment last updated: 2024-06-07 01:53:01)

files/en-us/glossary/color_space/index.md Outdated Show resolved Hide resolved

The _sRGB_ color space (standard red, green, and blue) was created for the web, but we are no longer limited to this color space. [CSS Color Module Level 4](https://drafts.csswg.org/css-color) specifies several predefined color spaces, and [CSS Color Module Level 5](https://drafts.csswg.org/css-color-5/) goes further, specifying features for defining custom color spaces.
The _sRGB_ color space (standard red, green, and blue) was created for the web, but we are no longer limited to this color space. [CSS Color Module Level 4](https://drafts.csswg.org/css-color-4) specifies several predefined color spaces, and [CSS Color Module Level 5](https://drafts.csswg.org/css-color-5/) goes further, specifying features for defining custom color spaces.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link cleanup (the official link points to css-color-4)

Screenshot 2024-05-04 at 4 24 58 PM

@@ -20,13 +20,13 @@ Color spaces are either [rectangular or polar](https://ericportis.com/posts/2024

### RGB color spaces

RGB is a color model that represents colors as mixtures of three underlying components — red, green, and blue color channels — that create various hues when combined. sRGB, or "Standard RGB", is the underlying color space for {{Glossary("RGB")}} colors. sRGB is intended as a common color space for the creation of images for viewing on the Internet and World Wide Web (WWW). sRGB is primarily used for displaying colors on computer screens, including laptops and smartphones.
RGB is a color model that represents colors as mixtures of three underlying components — red, green, and blue color channels — that create various hues when combined. sRGB, or "Standard RGB", is the underlying color space for {{Glossary("RGB")}} colors. sRGB is intended to serve the needs of PC and the {{glossary("world wide web", "Web")}} based imaging systems.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not just on Web

The aim of this color space is to complement the current color management strategies by enabling a third method of handling color in the operating systems, device drivers and the Internet that utilizes a simple and robust device independent color definition.

https://www.w3.org/Graphics/Color/sRGB

files/en-us/glossary/color_space/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much.

@PassionPenguin
Copy link
Contributor Author

Thanks very much.

thx for your kind review:)

(p.s. it may need a merge?)

@hamishwillee
Copy link
Collaborator

Yes! Sorry, forgot that part :-)

@hamishwillee hamishwillee merged commit e00b9c7 into mdn:main Jun 7, 2024
8 checks passed
@PassionPenguin PassionPenguin deleted the color-space branch June 7, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/s 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants