Add StorageAccessHandle #33391
Merged
Add StorageAccessHandle #33391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bsmth
reviewed
May 13, 2024
|
@bsmth have time for review? |
bsmth
approved these changes
May 21, 2024
There was a problem hiding this comment.
I've had a read through when you originally opened and checked again today, so I would leave a +1 to unblock you. Maybe @pepelsbey wants to have a look, but I think we can land it, IMO. Thank you!
|
Thanks! I could also use an eye on #33329 if you have time |
pepelsbey
reviewed
May 21, 2024
Co-authored-by: Vadim Makeev <[email protected]>
|
@sideshowbarker have time to merge this one too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the third of 3 PRs adding spec changes from https://privacycg.github.io/saa-non-cookie-storage/ launching in Chrome 125.
Motivation
StorageAccessHandle can be returned by requestStorageAccess when a types argument is provided to allow non-cookie unpartitioned storage access.
Additional details
https://chromestatus.com/feature/5175585823522816
Related issues and pull requests
Relates to mdn/mdn#543