Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint mdn links #33376

Merged
merged 6 commits into from
May 6, 2024
Merged

lint mdn links #33376

merged 6 commits into from
May 6, 2024

Conversation

PassionPenguin
Copy link
Contributor

@PassionPenguin PassionPenguin commented May 2, 2024 •
edited

  1. http => https for *mozilla.org
  2. https://developer.mozilla.org/en-US => /en-US (1 file)

and 861 more found occurences of "/en-US/docs/Glossary"..should i replace some of them?

@PassionPenguin PassionPenguin requested review from a team as code owners May 2, 2024 11:02
@PassionPenguin PassionPenguin requested review from wbamberg and teoli2003 and removed request for a team May 2, 2024 11:02
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:HTTP HTTP docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Meta Content in the meta docs size/s 6-50 LoC changed labels May 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited

Preview URLs (12 pages)
Flaws (14)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/2/Updating_extensions
Title: Updating extensions for Firefox 2
Flaw count: 5

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
  • broken_links:
    • Can't resolve /en-US/Install_Manifests
    • Can't resolve /en-US/Theme_changes_in_Firefox_2
    • Can't resolve /en-US/Install_Manifests#updateurl

URL: /en-US/docs/Mozilla/Firefox/Releases/3.5/Updating_extensions
Title: Updating extensions for Firefox 3.5
Flaw count: 9

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Submitting_an_add-on_to_AMO
    • Can't resolve /en-US/docs/Storage
    • Can't resolve /en-US/docs/XUL/textbox
    • Can't resolve /en-US/Using_native_JSON
    • Can't resolve /en-US/Security_changes_in_Firefox_3.5
    • and 2 more flaws omitted
External URLs (2)

URL: /en-US/docs/Mozilla/Firefox/Releases/2/Updating_extensions
Title: Updating extensions for Firefox 2

URL: /en-US/docs/Mozilla/Firefox/Releases/3.5/Updating_extensions
Title: Updating extensions for Firefox 3.5

(comment last updated: 2024-05-04 01:27:58)

@PassionPenguin @github-actions
Update files/en-us/web/api/document_object_model/examples/index.md
aa8aba9 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added size/m 51-500 LoC changed and removed size/s 6-50 LoC changed labels May 2, 2024
PassionPenguin
PassionPenguin commented May 2, 2024
View reviewed changes
files/en-us/web/api/document/createelementns/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/removeattributens/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/removeattributens/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/setattributenodens/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/setattributenodens/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/setattributens/index.md Outdated Show resolved Hide resolved
files/en-us/web/opensearch/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/namespaceuri/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/hasattributens/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/s 6-50 LoC changed and removed Content:Other Any docs not covered by another "Content:" label size/m 51-500 LoC changed labels May 2, 2024
@github-actions github-actions bot added the Content:Glossary Glossary entries label May 3, 2024
pepelsbey
pepelsbey approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pepelsbey pepelsbey merged commit 94ef07a into mdn:main May 6, 2024
8 checks passed
@PassionPenguin PassionPenguin deleted the lint-patch-1 branch May 6, 2024 09:19
PassionPenguin added a commit to PassionPenguin/translated-content that referenced this pull request May 6, 2024
@PassionPenguin
sync with mdn/content#33376
7666ba2 
related hash 94ef07a7b073c2663cbace0667bdb717a40bfa28
@PassionPenguin PassionPenguin mentioned this pull request May 6, 2024
Merged
wbamberg
wbamberg reviewed May 6, 2024
View reviewed changes
files/en-us/glossary/camel_case/index.md
Comment on lines +21 to +22
- {{Glossary("Snake_case", "Snake Case")}}
- {{Glossary("Kebab_case", "Kebab Case")}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text ought to be "Snake case" and "Kebab case".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, you are right.

PassionPenguin added a commit to PassionPenguin/content that referenced this pull request May 6, 2024
@PassionPenguin
fix: patch link name
977407f 
see mdn#33376 (comment)
@PassionPenguin PassionPenguin mentioned this pull request May 6, 2024
Merged
wbamberg pushed a commit that referenced this pull request May 7, 2024
@PassionPenguin
fix: patch link name (#33454)
4087e29 
see #33376 (comment)
dalps pushed a commit to dalps/content that referenced this pull request May 8, 2024
@PassionPenguin @dalps
fix: patch link name (mdn#33454)
f80098e 
see mdn#33376 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg left review comments

@github-actions github-actions[bot] github-actions left review comments

@pepelsbey pepelsbey pepelsbey approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 is a code owner automatically assigned from mdn/yari-content-http

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:Glossary Glossary entries Content:HTTP HTTP docs Content:Learn Learning area docs Content:Meta Content in the meta docs Content:WebAPI Web API docs size/s 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PassionPenguin @pepelsbey @wbamberg