Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTMLTableColElement.{align|valign} #33101

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Add HTMLTableColElement.{align|valign} #33101

merged 7 commits into from
Jun 18, 2024

Conversation

teoli2003
Copy link
Member

@teoli2003 teoli2003 commented Apr 15, 2024

Description

This PR adds docs for the following properties:

  • HTMLTableColElement.align
  • HTMLTableColElement.valignign`

Motivation

These properties are supported by all engines.

Though deprecated, they are common tasks for beginners: we need documentation that points to the right way of doing this (TM), using text-align and vertical-align and td:nth-child()

Additional details

There is no example as this is deprecated: the example sections point to examples using the modern (CSS) way of doing it so that they are one click away.

I used the same structure as in #32993.

Related issues and pull requests

It is part of mdn/mdn#520

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m 51-500 LoC changed labels Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

Preview URLs

Flaws (2)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLTableColElement/align
Title: HTMLTableColElement: align property
Flaw count: 2

  • macros:
    • Unknown macro td
    • Unknown macro th

(comment last updated: 2024-06-18 17:44:53)

@teoli2003 teoli2003 requested a review from estelle April 15, 2024 09:58
@teoli2003 teoli2003 marked this pull request as ready for review April 15, 2024 09:58
@teoli2003 teoli2003 requested review from a team as code owners April 15, 2024 09:58
@teoli2003 teoli2003 requested review from Elchi3 and removed request for a team April 15, 2024 09:58
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback

files/en-us/web/api/htmltablecolelement/align/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecolelement/align/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecolelement/align/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecolelement/align/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions for previous commentd

files/en-us/web/api/htmltablecolelement/align/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecolelement/align/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
@estelle estelle merged commit 601447d into mdn:main Jun 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants