Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property name iceTransport #33069

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fix property name iceTransport #33069

merged 2 commits into from
Apr 15, 2024

Conversation

Justme0
Copy link
Contributor

@Justme0 Justme0 commented Apr 13, 2024

The property name iceTransport of RTCDtlsTransport is not transport.

Description

Motivation

Additional details

Related issues and pull requests

@Justme0
Fix property name iceTransport
530ae06 
The property name `iceTransport` of `RTCDtlsTransport` is not `transport`.
@Justme0 Justme0 requested a review from a team as a code owner April 13, 2024 03:50
@Justme0 Justme0 requested review from Elchi3 and removed request for a team April 13, 2024 03:50
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Apr 13, 2024
hamishwillee
hamishwillee approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Good catch

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/API/RTCIceCandidatePair/local
Title: RTCIceCandidatePair: local property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.RTCIceCandidatePair.local

@hamishwillee hamishwillee merged commit 29b4592 into mdn:main Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Justme0 @hamishwillee