-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial review: CSS Anchor Positioning landing page and guide #33058
Merged
chrisdavidmills
merged 70 commits into
mdn:main
from
chrisdavidmills:css-anchor-positioning-1
Jun 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
9e31158
CSS Anchor Positioning landing page and tutorial
chrisdavidmills 20bf5f6
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills 8ec419d
first part of guide
chrisdavidmills b197523
Add anchor() example
chrisdavidmills 4d0836d
Add description and example of inst-area
chrisdavidmills b6012eb
Another couple fo sections done
chrisdavidmills 50dabaa
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills 93204bc
Final content updates
chrisdavidmills 3df35bc
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills 3072147
Add inset-area() function to landing page
chrisdavidmills 759020f
Merge branch 'css-anchor-positioning-1' of github.com:chrisdavidmills…
chrisdavidmills 8b44357
Fixes for mfreed7 review comments
chrisdavidmills 3a1eab2
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills 0a64f95
Few more fixes for mfreed7 review comments
chrisdavidmills ee4f0c2
Update the position-try-order demo to use inset properties rather tha…
chrisdavidmills 30de3ec
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills 25b4efd
Remove position-try-order
chrisdavidmills 998bcf1
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills a7f7f15
typo fix
chrisdavidmills 0b17054
add back position-try-order
chrisdavidmills 7a2a558
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills 02b65b6
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills 4ab329c
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills c704730
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills 95abeca
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills f553a16
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills e6aaf4d
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills 5b9fea7
Partial fixes; more to come
chrisdavidmills efc36f2
Fixes for estelle review comments
chrisdavidmills 1237adf
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills b1a6a23
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills 1d95627
Next round of fixes for estelle review comments
chrisdavidmills 5affd38
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 319b01e
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills d90b1fb
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills febeb77
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 7df5a41
Update files/en-us/web/css/css_anchor_positioning/index.md
chrisdavidmills 3c86b63
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills be3fa5c
change anchor name to be more distinct and less confusion
chrisdavidmills d9b0703
Split guide into two
chrisdavidmills e59c317
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills c6dd389
Added link to inset-area type
chrisdavidmills a8b9dee
fixes for estelle review comments
chrisdavidmills 2e5fb62
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 27650a9
Update files/en-us/web/css/css_anchor_positioning/try_options_hiding/…
chrisdavidmills 4a35de4
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 2f19e93
Update files/en-us/web/css/css_anchor_positioning/try_options_hiding/…
chrisdavidmills 2dd3330
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 2d542f5
small terminology fix
chrisdavidmills 3080bfe
module page suggestions
estelle 8c9557b
Edits to the first guide
estelle 1ba2c5a
update inset-area row and column values info
chrisdavidmills da5217c
Merge pull request #2 from mdn/ap1
chrisdavidmills 1938693
Merge pull request #3 from mdn/ap1-guide1
chrisdavidmills f8dad40
a few fixes to make
chrisdavidmills 32d6904
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills e716b52
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills c3d139f
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 856795c
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 51012ab
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 0897b72
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills ae88d9a
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills fd7befd
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills 3b5e5b7
Update files/en-us/web/css/css_anchor_positioning/using/index.md
chrisdavidmills c580a57
Update files/en-us/web/css/css_anchor_positioning/using/inset-area.dr…
chrisdavidmills 4072d32
Final fixes to using guide
chrisdavidmills 60390c7
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills 1898599
Add anchor() info to make association vs position clear, and clarify …
chrisdavidmills b9f13a5
Fixes for estelle review comments
chrisdavidmills b3a3905
Merge branch 'main' into css-anchor-positioning-1
chrisdavidmills File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Final fixes to using guide
- Loading branch information
commit 4072d32a0e845462d4df5efb0e49aee715f678a0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would love to break this into two. I think we need to. Brain is fried by the time i get here.
Can we do part 1: association, tether, to size, and add the difference between fixed and absolute (which needs to be added), with part 2 being positioning: anchor(), inset-area, and anchor center should be together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really rather not. I want to get this published before Christmas.
Seriously though, it feels a lot more intense when you are editing an article. When you are just reading it, it will be OK.