fix: Use callback for toBlob in clipboard write example #33000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs (comment last updated: 2024-05-03 14:00:48) |
|
I haven't reviewed this properly yet, but I will. However, what do you think about making this into a live sample? As I read the issue, this example was completely broken before, but it got through review (my review in fact) because it wasn't a live sample. |
Josh-Cena
reviewed
Apr 8, 2024
Josh-Cena
reviewed
Apr 8, 2024
Josh-Cena
reviewed
Apr 8, 2024
It would definitely be more interesting, let's do that. I'll give it a shot shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the example to use a callback in toBlob(). I'm not adding more elements like an
<output>or adding image back to DOM as I think it overcomplicates things here.I can confirm that this copies the image to clipboard, see the following codepen: https://codepen.io/bsmth/pen/OJGvoLV
Fixes #32385