Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTMLTable{Row|Cell}.bgColor #32994

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Add HTMLTable{Row|Cell}.bgColor #32994

merged 10 commits into from
Apr 10, 2024

Conversation

teoli2003
Copy link
Member

Description

This PR adds docs for the two properties:

  • HTMLTableCellElement.bgColor
  • HTMLTableRowElement.bgColor

Motivation

These properties are supported by all engines.

Though deprecated, they are common tasks for beginners: we need documentation that points to the right way of doing this (TM), using background-color.

Additional details

There is no example as this is deprecated: the example sections point to examples using the modern (CSS) way of doing it so that they are one click away.

Related issues and pull requests

It is part of mdn/mdn#520

@teoli2003 teoli2003 requested review from a team as code owners April 8, 2024 08:51
@teoli2003 teoli2003 requested review from wbamberg and dipikabh and removed request for a team April 8, 2024 08:51
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

files/en-us/web/api/htmltablecellelement/bgcolor/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecellelement/bgcolor/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecellelement/bgcolor/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecellelement/bgcolor/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablecellelement/bgcolor/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablerowelement/bgcolor/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltablerowelement/bgcolor/index.md Outdated Show resolved Hide resolved

## Examples

Use CSS `background-color` instead. An [example](/en-US/docs/Web/CSS/background-color#colorize_tables) is available on the {{cssxref("background-color")}} page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same suggestion as above

files/en-us/web/css/background-color/index.md Show resolved Hide resolved
files/en-us/web/css/background-color/index.md Show resolved Hide resolved
@wbamberg wbamberg removed their request for review April 10, 2024 15:09
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@estelle estelle merged commit fe9e5fa into mdn:main Apr 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants