Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editorial review: Add docs for notRestoredReasons #32920

Merged
merged 69 commits into from
Apr 12, 2024

Conversation

chrisdavidmills
Copy link
Contributor

Description

#27947 contains the engineering technical review for my work on notRestoredReasons docs, which has been completed and approved. Thank you to @tunetheweb for your thorough and detailed review work.

This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.


Background information

The PerformanceNavigationTiming.notRestoredReasons property is finally going to be launched in Chrome 123. This PR adds a reference page for the property and associated interfaces, and a guide to using it.

See https://developer.chrome.com/docs/web-platform/bfcache-notrestoredreasons/ for further details

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners April 2, 2024 07:41
@chrisdavidmills chrisdavidmills requested review from wbamberg and pepelsbey and removed request for a team April 2, 2024 07:41
@github-actions github-actions bot added Content:WebAPI Web API docs size/l 501-1000 LoC changed labels Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Copy link
Contributor

@skyclouds2001 skyclouds2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those self-links is better not to kept

files/en-us/web/api/notrestoredreasons/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/notrestoredreasons/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/notrestoredreasondetails/index.md Outdated Show resolved Hide resolved
@wbamberg wbamberg removed their request for review April 2, 2024 16:51
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the glossary page, and addressing my other feedback! There are some links to update still but I think this could land with the fixes submitted

files/en-us/glossary/bfcache/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/notrestoredreasondetails/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/notrestoredreasons/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/notrestoredreasons/tojson/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/notrestoredreasons/url/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/notrestoredreasons/url/index.md Outdated Show resolved Hide resolved
chrisdavidmills and others added 26 commits April 12, 2024 10:12
@chrisdavidmills chrisdavidmills merged commit 3148591 into mdn:main Apr 12, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the notrestoredreasons branch April 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries Content:WebAPI Web API docs size/l 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants