Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy.ProxyInfo.proxyAuthorizationHeader HTTP support #32536

Merged

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Mar 4, 2024

Description

Amended the description of 'proxy.ProxyInfo.proxyAuthorizationHeader' to note that it also supports setting for HTTP proxies. This change was made in Bug 1794464
Allow HTTP authentication in proxy.onRequest.

Related issues and pull requests

Fixes #32475

@rebloor rebloor added the Content:WebExt WebExtensions docs label Mar 4, 2024
@rebloor rebloor self-assigned this Mar 4, 2024
@rebloor rebloor requested a review from a team as a code owner March 4, 2024 01:59
@rebloor rebloor requested review from willdurand and removed request for a team March 4, 2024 01:59
@github-actions github-actions bot added the size/xs 0-5 LoC changed label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/125
Title: Firefox 125 for developers

(comment last updated: 2024-04-04 17:54:08)

@erosman
Copy link
Contributor

erosman commented Mar 8, 2024

I think a note to state that the support was added in Firefox 125 would avoid unnecessary confusion for the developers (especially since it is not out as standard release yet).

@rpl
Copy link
Member

rpl commented Mar 19, 2024

I think a note to state that the support was added in Firefox 125 would avoid unnecessary confusion for the developers (especially since it is not out as standard release yet).

@rebloor @Rob--W could that fit into a note added into a browser-compat-data/webextensions/api/proxy.json? wdyt?

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @rebloor

@rebloor
Copy link
Contributor Author

rebloor commented Mar 19, 2024

@rpl added BCD note in mdn/browser-compat-data#22668. I'll also add release note shortly.

@rebloor rebloor requested a review from a team as a code owner March 20, 2024 01:32
@rebloor rebloor requested review from hamishwillee and removed request for a team March 20, 2024 01:32
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Mar 20, 2024
@rebloor rebloor requested a review from rpl March 20, 2024 01:35
@rebloor rebloor requested a review from dotproto April 4, 2024 17:53
Copy link
Collaborator

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamishwillee hamishwillee removed their request for review April 12, 2024 00:34
@rebloor rebloor merged commit ca34c2a into mdn:main Apr 12, 2024
9 checks passed
@rebloor rebloor deleted the proxy.ProxyInfo.proxyAuthorizationHeader-HTTP-support branch April 12, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebExt WebExtensions docs size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP to proxy.ProxyInfo 'proxyAuthorizationHeader'
4 participants