Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add document for HTMLButtonElement.type #32024

Merged
merged 4 commits into from
Feb 13, 2024
Merged

add document for HTMLButtonElement.type #32024

merged 4 commits into from
Feb 13, 2024

Conversation

ShubhamOulkar
Copy link
Contributor

This PR add documentation for HTMLButtonElement.type

It is part of mdn/mdn#520

Resource
type

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner January 31, 2024 11:56
@ShubhamOulkar ShubhamOulkar requested review from wbamberg and removed request for a team January 31, 2024 11:56
@github-actions github-actions bot added Content:WebAPI Web API docs size/s 6-50 LoC changed labels Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/API/HTMLButtonElement/type
Title: HTMLButtonElement: type property
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLTextAreaElement/type does not exist
    • /en-US/docs/Web/API/HTMLInputElement/type does not exist

(comment last updated: 2024-02-11 19:36:32)

@ShubhamOulkar ShubhamOulkar changed the title add Document for HTMLButtonElement.type add document for HTMLButtonElement.type Jan 31, 2024
ShubhamOulkar and others added 2 commits February 1, 2024 08:23
@ShubhamOulkar @dawei-wang
typo
de299ec 
Co-authored-by: dawei-wang <[email protected]>
@ShubhamOulkar @skyclouds2001
typo
dabe702 
Co-authored-by: skyclouds2001 <[email protected]>
dawei-wang
dawei-wang reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@dawei-wang dawei-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

teoli2003
teoli2003 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 34d914d into mdn:main Feb 13, 2024
8 checks passed
@ShubhamOulkar ShubhamOulkar deleted the HTMLButtonElement.type branch February 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawei-wang dawei-wang dawei-wang left review comments

@teoli2003 teoli2003 teoli2003 approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

@skyclouds2001 skyclouds2001 Awaiting requested review from skyclouds2001

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ShubhamOulkar @teoli2003 @dawei-wang @skyclouds2001 @Josh-Cena