Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html): update resolution switching demo pros #30902

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix(html): update resolution switching demo pros #30902

merged 3 commits into from
Jun 21, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The updates assert that the rendered image size doesn't change but the image quality does change on higher resolution displays.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner December 10, 2023 11:08
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team December 10, 2023 11:08
@github-actions github-actions bot added the Content:Learn:HTML Learning area HTML docs label Dec 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2023 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images
Title: Responsive images

(comment last updated: 2024-05-04 02:12:08)

@hamishwillee
Copy link
Collaborator

hamishwillee commented Dec 10, 2023 •
edited
Loading

@OnkarRuikar Thanks very much. I've subedited the English a little.

I haven't approved because even though this is better, do you think we could improve the example by displaying the three source images below, allowing the user to compare the versions they might get on each screen (and noting that you would only see the benefit on a higher resolution screen)? Most of the time this should be useful and make the effects more obvious, in particular because we most people will have better than the crappiest screen by default.

@chrisdavidmills chrisdavidmills removed their request for review December 11, 2023 09:50
@OnkarRuikar OnkarRuikar mentioned this pull request Dec 16, 2023
Open
@OnkarRuikar
Copy link
Contributor Author

do you think we could improve the example by displaying the three source images below

@hamishwillee I've updated the example in learning-area repo: mdn/learning-area#696

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed merge conflicts 🚧 [PR only] labels May 4, 2024
hamishwillee
hamishwillee approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much

@hamishwillee hamishwillee merged commit b275722 into mdn:main Jun 21, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the html_srcset_res_switching branch June 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
Content:Learn:HTML Learning area HTML docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "Responsive images": cannot see a change to the image
2 participants
@OnkarRuikar @hamishwillee