Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use git add command in the reviewdog workflow #28443

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

OnkarRuikar
Copy link
Contributor

Fixes https://github.com/mdn/content/actions/runs/5793903831/job/15702484911#step:4:22

On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
(use "git add ..." to include in what will be committed)
files/en-us/web/api/rtcencodedvideoframe/

nothing added to commit but untracked files present (use "git add" to track)
Error: Process completed with exit code 1.

Problem is git -am considers only modified files. We need to use git add separately.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner August 8, 2023 08:06
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Aug 8, 2023
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, ta

@LeoMcA LeoMcA merged commit 4a90e2c into mdn:main Aug 8, 2023
5 of 6 checks passed
@OnkarRuikar OnkarRuikar deleted the OnkarRuikar-patch-1-3 branch August 9, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants