Fix front-matter_linter when called with --verbose #28231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chalk is transitively installed in this repo from Yari and Jest. Does this actually cause failures if we add |
|
I don't see how it could, but I don't think it's worth it to add an entire import for one single line, especially if we do not have the package added as a direct dependency. And I don't think we should add an entire dependency for the one single line either. (Note: on Unix, the output of the console error is already colored red, so the line is redundant anyways.) |
|
Sure, that sounds okay to me. Just putting a random thought. |
|
This PR is still in need of review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the front-matter linter when called with the
--verboseoption. The script attempts to callchalk.red(), howeverchalkis not a dependency of the project, let alone imported by the script.