Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github/issue-labeler from 2.6 to 3.0 #24319

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Bump github/issue-labeler from 2.6 to 3.0 #24319

merged 2 commits into from
Feb 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 10, 2023

Bumps github/issue-labeler from 2.6 to 3.0.

Release notes

Sourced from github/issue-labeler's releases.

v3.0

What's Changed

Breaking change: Issue labels that do not match a regex will no longer be removed by default unless you set sync-labels: to 1

Full Changelog: github/issue-labeler@v2.6...v3.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump github/issue-labeler from 2.6 to 3.0
99da628 
Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.6 to 3.0.
- [Release notes](https://github.com/github/issue-labeler/releases)
- [Commits](github/issue-labeler@v2.6...v3.0)

---
updated-dependencies:
- dependency-name: github/issue-labeler
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner February 10, 2023 14:56
@dependabot dependabot bot added dependencies [PR only] Pull requests that update a dependency file github actions [PR only] Pull requests that update GitHub Actions code labels Feb 10, 2023
@Josh-Cena
Copy link
Member

I wonder if we should enable the sync-labels option or not... github/issue-labeler#59

@bsmth
Copy link
Member

bsmth commented Feb 10, 2023

I wonder if we should enable the sync-labels option or not...

From what I gather according to the release notes, it looks like this won't make a difference for us:

Issue labels that do not match a regex will no longer be removed by default

Issues coming from pages are using the issue template, this breaking change will not remove labels by default if someone adds one e.g. from here is that correct?

@Josh-Cena Josh-Cena mentioned this pull request Feb 13, 2023
Closed
@caugner
Copy link
Contributor

caugner commented Feb 14, 2023

Issue labels that do not match a regex will no longer be removed by default

@bsmth Based on the changes in the upstream PR, labels are no longer removed if the corresponding regex no longer matches.

Example: Let's say a PR updates a CSS page, then the labeler will assign the Content: CSS label. So far, no change. Now, if the PR is updated to revert the CSS page and update an HTML page, the behavior changes. Previously, it would remove the Content: CSS label and add the Content: HTML label. Now, it only adds the Content: HTML and does NOT remove the Content: CSS label (unless the sync-labels option on the workflow is set to 1/true).

I think we do want to set sync-labels: 1 on the workflow to maintain the previous behavior.

@Josh-Cena
Copy link
Member

@caugner AFAICT, this workflow is only used to label issues, not PRs.

@caugner
Copy link
Contributor

caugner commented Feb 14, 2023

AFAICT, this workflow is only used to label issues, not PRs.

You're right, I mixed it up with the PR labeler. I guess issue descriptions change so rarely that it's kind of an edge case, but maybe still worth keeping the previous behavior?

@bsmth
Copy link
Member

bsmth commented Feb 14, 2023

I think we do want to set sync-labels: 1 on the workflow to maintain the previous behavior.

I'm going to add this to this PR

@bsmth bsmth merged commit 4ed6638 into main Feb 14, 2023
@bsmth bsmth deleted the dependabot/github_actions/github/issue-labeler-3.0 branch February 14, 2023 08:53
@bsmth bsmth mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
dependencies [PR only] Pull requests that update a dependency file github actions [PR only] Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Josh-Cena @bsmth @caugner