Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Module landing page: filter effects #24261

Merged
merged 13 commits into from
Feb 16, 2023
Merged

CSS Module landing page: filter effects #24261

merged 13 commits into from
Feb 16, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 7, 2023

No description provided.

@estelle estelle requested a review from a team as a code owner February 7, 2023 21:42
@estelle estelle requested review from dipikabh and removed request for a team February 7, 2023 21:42
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023 •
edited

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/Filter_Effects
Title: CSS filter effects
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

(comment last updated: 2023-02-16 07:10:37)

dipikabh
dipikabh requested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @estelle! I don't see the sample in action and a few more comments

files/en-us/web/css/filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/index.md
## Reference
### Filter effects in action

Play with the various sliders to apply filter effects to the image below:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing any changes in the image when I move the sliders (chrome, firefox)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdn/css-examples#116 fixes it. fingers crossed

files/en-us/web/css/filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/index.md Outdated Show resolved Hide resolved
@estelle @dipikabh
Apply suggestions from code review
9ef17af 
Co-authored-by: Dipika Bhattacharya <[email protected]>
@dipikabh
Copy link
Contributor

  • PR test is failing here:

    error: FixableError: files/en-us/web/css/filter_effects/george_floyd_memorial_sm.jpg can be removed, because it is not mentioned in files/en-us/web/css/filter_effects/index.md

  • The updates look good to me, so approved. I guess the changes in css-examples will take a while to show up.

  • Not a blocker for this pull request, but in general, I am not feeling so sure about the heading “Related concepts” any more. The list of properties, data types, functions in the "Related concepts" section are “Related” to the current module page but they're not really “concepts”. A concept topic would be something guide’y. The list in this section, on the other hand, are just links to related reference pages.
    Would it be better to call the heading “Related references”?

@estelle estelle merged commit 29e693a into mdn:main Feb 16, 2023
@estelle estelle deleted the filtermod branch March 29, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@estelle @dipikabh @teoli2003