CSS Module: backgrounds and borders #24123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs Flaws (3)URL:
(comment last updated: 2023-02-08 02:53:57) |
dipikabh
requested changes
Feb 6, 2023
Comment on lines
+135
to
+136
| - [Learn CSS: the box model](/en-US/docs/Learn/CSS/Building_blocks/The_box_model) | ||
| - : Explains how borders, along with other box model properties, impact the CSS box model. |
There was a problem hiding this comment.
Do you want to move this right after 'Learn CSS: background and borders' so that all learn links are together?
There was a problem hiding this comment.
This one is more tangentially related to this module, which is why I didn't put it second.
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
|
Thanks for the review! |
dipikabh
previously requested changes
Feb 8, 2023
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Feb 8, 2023
…to common-questions-consistency * origin/common-questions-consistency: Update CSS/atan2 (mdn#24274) Bump @mdn/yari from 1.36.2 to 2.0.2 (mdn#24270) Bump prettier from 2.8.3 to 2.8.4 (mdn#24271) Remove "Using XMLHttpRequest in IE6" article (mdn#24269) Update `sandbox` keyword descriptions (mdn#23622) Add info about restrictions to `Domain` in `set-cookie` (mdn#23780) Document `Element.animate()`'s `timeline` option (mdn#24009) fix broken links in yari testing document (mdn#24265) add cite attribute to cite element (mdn#24257) Fix (another) typo in `gesturestart` (mdn#24249) Run Prettier over Intl references (mdn#24142) Run Prettier over Global objects O–W (mdn#24141) CSS Module: backgrounds and borders (mdn#24123) Add more examples to illustrate CSS var() usage (mdn#23860) Add missing word (mdn#24262) Reference documentation for the CSS Custom highlight API (mdn#23907) Fix some minor typos (mdn#24258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes box shadow, border image, and collapsing borders between table cells.
The list of related border properties are in the logical properties spec.