Revert "Fix color contrast" #24040
Merged
Revert "Fix color contrast" #24040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45ceb67.
|
Preview URLs (comment last updated: 2023-02-02 19:29:16) |
|
In this case, maybe either add an editorial note (Markdown comment) or an in-code comment that it's intended and there's no a11y issue? |
|
I added a comment. Oddly, no one has issues with the barely visible shadow in the previous example on the page. |
Josh-Cena
reviewed
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23569
box shadows don't need to match WCAG text color contrasts. About 15 people have attempted to alter this example over the past 6 months because the colors are the colors of the trans flag.