Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Remove dropped CSS rule, bump react versions & link to deploy #23579

Merged
merged 1 commit into from
Jan 13, 2023
Merged

chore(deps): Remove dropped CSS rule, bump react versions & link to deploy #23579

merged 1 commit into from
Jan 13, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 12, 2023

This PR has the following changes:

Related issues and pull requests:

@bsmth bsmth requested a review from a team as a code owner January 12, 2023 15:52
@bsmth bsmth requested review from hamishwillee and dipikabh and removed request for a team January 12, 2023 15:52
@github-actions github-actions bot added the Content:Learn Learning area docs label Jan 12, 2023
@github-actions
Copy link
Contributor

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_todo_list_beginning
Title: Beginning our React todo list
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
Title: Accessibility in React
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on
External URLs (2)

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks
Title: Understanding client-side JavaScript frameworks

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
Title: Accessibility in React

@bsmth bsmth mentioned this pull request Jan 12, 2023
Merged
2 tasks
dipikabh
dipikabh requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very tiny nit. The other changes look okay.

...learn/tools_and_testing/client-side_javascript_frameworks/react_todo_list_beginning/index.md Show resolved Hide resolved
@bsmth bsmth requested a review from dipikabh January 13, 2023 13:21
@dipikabh dipikabh merged commit 9b89a7d into mdn:main Jan 13, 2023
@bsmth bsmth deleted the todo-react-updates branch January 13, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Learn Learning area docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsmth @dipikabh