Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(CSS): Anchor elements are not referring to '<a>' but to the anchoring element #23416

Merged
merged 4 commits into from
Jan 7, 2023
Merged

docs(CSS): Anchor elements are not referring to '<a>' but to the anchoring element #23416

merged 4 commits into from
Jan 7, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 5, 2023

We had some changes land recently that pointed to anchor elements (<a>) where the docs are actually referring to "relative-selector-anchor-elements" -> https://drafts.csswg.org/selectors/#relative-selector-anchor-elements

From the spec:

CSS Description
E:has(rs1, rs2) an E element, if there exists an element that matches either of the relative selectors rs1 or rs2, when evaluated with E as the anchor elements

Fixes #22917

@bsmth bsmth requested a review from estelle January 5, 2023 16:47
@bsmth bsmth requested a review from a team as a code owner January 5, 2023 16:47
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023 •
edited

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/CSS_Selectors
Title: CSS selectors
Flaw count: 1

  • macros:
    • /en-US/docs/Web/HTML/Element/h2 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements

(comment last updated: 2023-01-07 19:22:54)

estelle
estelle requested changes Jan 5, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Let's revert the changes. I think it's better to not add a link if it's not a link directly to the definition

@bsmth
Copy link
Member Author

bsmth commented Jan 6, 2023

Thanks @estelle, incorporated your suggestions 👍🏻

@estelle estelle merged commit ba9bc4f into mdn:main Jan 7, 2023
@bsmth bsmth deleted the 22917-relative-selectors branch May 26, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Section on "relative selectors" mentions "anchor element" with incorrect link?
2 participants
@bsmth @estelle