Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22892 range tick mark #23135

Merged
merged 10 commits into from
Dec 29, 2022
Merged

22892 range tick mark #23135

merged 10 commits into from
Dec 29, 2022

Conversation

dletorey
Copy link
Contributor

Description

  • Updates the references to the tickmarks datalist.
  • Added and updated examples

Motivation

Making sure docs were upto date for the FF release of list attribute for input type range

Additional details

While doing this I discovered an accessibility bug in Firefox related to step="any"

Related issues and pull requests

Fixes #22892

@dletorey dletorey requested a review from a team as a code owner December 22, 2022 15:26
@dletorey dletorey requested review from estelle and removed request for a team December 22, 2022 15:26
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Dec 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

Preview URLs

Flaws (3)

URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/valueAsNumber does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/HTML/Constraint_validation
    • Can't resolve /en-US/docs/Web/Guide/HTML/Constraint_validation

(comment last updated: 2022-12-23 09:57:16)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions and corrections. And I learned stuff! Thank you for the edits.

files/en-us/web/html/element/input/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/range/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/input/range/index.md Outdated Show resolved Hide resolved
### step

The `step` attribute is a number that specifies the granularity that the value must adhere to, or the special value `any`, which is described below. Only values which are equal to the basis for stepping ([`min`](#min) if specified, {{htmlattrxref("value", "input")}} otherwise, and an appropriate default value if neither of those is provided) are valid.

A string value of `any` means that no stepping is implied, and any value is allowed (barring other constraints, such as [`min`](#min) and [`max`](#max)).
A string value of `any` means that no stepping is implied, and any value is allowed (barring other constraints, such as [`min`](#min) and [`max`](#max)). See the [Setting step to "any"](#setting_step_to_any) example for how this works in supported browsers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A string value of `any` means that no stepping is implied, and any value is allowed (barring other constraints, such as [`min`](#min) and [`max`](#max)). See the [Setting step to "any"](#setting_step_to_any) example for how this works in supported browsers.
A string value of `any` means that no stepping is implied, and any value is allowed (barring other constraints, such as [`min`](#min) and [`max`](#max)). See the [Setting step to `any`](#setting_step_to_any) example for how this works in supported browsers.


> **Note:** When the data entered by the user doesn't adhere to the stepping configuration, the {{Glossary("user agent")}} may round to the nearest valid value, preferring numbers in the positive direction when there are two equally close options.
> **Note:** When the data entered by the user doesn't adhere to the stepping configuration, the {{Glossary("user agent")}} may round to the nearest valid value, preferring to round up numbers when there are two equally close options.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note:** When the data entered by the user doesn't adhere to the stepping configuration, the {{Glossary("user agent")}} may round to the nearest valid value, preferring to round up numbers when there are two equally close options.
> **Note:** When the data entered by the user doesn't adhere to the stepping configuration, the {{Glossary("user agent")}} may round to the nearest valid value, preferring to round numbers up when there are two equally close options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected these

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two grammar edits. Looks great. Thank you.

@estelle estelle merged commit f8159d9 into mdn:main Dec 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTML] Update doc for tick mark support for <input type=range> when @list/<datalist> is used
2 participants