Apply suggestions from review

Co-authored-by: Rob Wu <[email protected]>
mdn · rebloor · Feb 14, 2023 · Nov 30, 2022 · Dec 2, 2022 · Dec 5, 2022
commit 7173fd62d14623a746f1f2a6d7fb4acc1cdbddb1
@@ -113,7 +113,7 @@ The number of dynamic and session-scoped rules an extension can add is limited t
 
 When the browser evaluates how to handle requests, it checks each extension's rules that have a condition that matches the request and chooses the one to consider applying as follows:
 
-1. the rule priority, where 1 is the highest priority (and rules default to 1 where priority is not set)
+1. the rule priority, where 1 is the lowest priority (and rules default to 1 where priority is not set)
  If this doesn't result in one rule to apply:
 2. the rule action, in the following order of precedence:
  1. "allow" which means any other remaining rules are ignored.
@@ -165,7 +165,7 @@ If the request was not blocked or redirected, the matching `modifyHeaders` actio
 - {{WebExtAPIRef("declarativeNetRequest.ResourceType")}}
  - : The resource type of a request.
 - {{WebExtAPIRef("declarativeNetRequest.Rule")}}
- - : An object containing details of a dynamic rule.
+ - : An object containing details of a rule.
 - {{WebExtAPIRef("declarativeNetRequest.RuleAction")}}
  - : An object defining the action to take if a rule is matched.
 - {{WebExtAPIRef("declarativeNetRequest.RuleCondition")}}
@@ -186,11 +186,11 @@ If the request was not blocked or redirected, the matching `modifyHeaders` actio
 - {{WebExtAPIRef("declarativeNetRequest.MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES")}}
  - : The maximum number of combined dynamic and session scoped rules an extension can add.
 - {{WebExtAPIRef("declarativeNetRequest.MAX_NUMBER_OF_ENABLED_STATIC_RULESETS")}}
- - : The maximum number of static `Rulesets` an extension can enable.
+ - : The maximum number of static rulesets an extension can enable.
 - {{WebExtAPIRef("declarativeNetRequest.MAX_NUMBER_OF_REGEX_RULES")}}
  - : The maximum number of regular expression rules that an extension can add.
 - {{WebExtAPIRef("declarativeNetRequest.MAX_NUMBER_OF_STATIC_RULESETS")}}
- - : The maximum number of static `Rulesets` an extension can specify as part of the [`"rule_resources"`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/rule_resources) manifest key.
+ - : The maximum number of static rulesets an extension can specify as part of the [`declarative_net_request.rule_resources`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request) manifest key.
 - {{WebExtAPIRef("declarativeNetRequest.SESSION_RULESET_ID")}}
  - : The ruleset ID for the session-scoped rules added by the extension.
 

@@ -21,13 +21,13 @@ Checks if a regular expression is supported as a {{WebExtAPIRef("declarativeNetR
 
 ```js-nolint
 let count = browser.declarativeNetRequest.isRegexSupported(
- RegexOptions // object
+ regexOptions // object
 );
 ```
 
 ### Parameters
 
-- `RegexOptions`
+- `regexOptions`
 
  - : An object containing the regular expression to check.
  - `isCaseSensitive` {{optional_inline}}

@@ -18,7 +18,7 @@ browser-compat: webextensions.api.declarativeNetRequest.MAX_NUMBER_OF_ENABLED_ST
 
 The maximum number of static rulesets an extension can have enabled, i.e., the number of values in the [`declarative_net_request.rule_resources`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request) manifest key with `"enabled"` set to `true`. Static rulesets exceeding the limit are ignored.
 
-An extension can change the number of enabled rulesets using the {{WebExtAPIRef("declarativeNetRequest.updateEnabledRulesets", "updateEnabledRulesets"}} method.
+An extension can change the number of enabled rulesets using the {{WebExtAPIRef("declarativeNetRequest.updateEnabledRulesets", "updateEnabledRulesets")}} method.
 
 Its value is `10`.
 

@@ -16,7 +16,7 @@ browser-compat: webextensions.api.declarativeNetRequest.MAX_NUMBER_OF_STATIC_RUL
 
 {{AddonSidebar()}}
 
-The maximum number of static rulesets an extension can specify as part of the [`"rule_resources"`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request) manifest key.
+The maximum number of static rulesets an extension can specify as part of the [`declarative_net_request.rule_resources`](/docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request) manifest key.
 
 Its value is `50`.
 

@@ -66,12 +66,12 @@ Events have three functions:
  - `tabId`
  - : A `number`. The ID of the tab in which the request takes place. Set to `-1` if the request is not related to a tab.
  - `type`
- - : [`ResourceType`](/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/ResourceType). The resource type of the request.
+ - : {{WebExtAPIRef("declarativeNetRequest.ResourceType", "ResourceType")}}. The resource type of the request.
  - `url`
  - : A `string`. The URL of the request.
 
  - `rule`
- - : [`MatchedRule`](/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MatchedRule). Details of a matched rule.
+ - : {{WebExtAPIRef("declarativeNetRequest.MatchedRule", "MatchedRule")}}. Details of a matched rule.
 
 {{WebExtExamples}}
 

@@ -20,7 +20,9 @@ Configures whether the action count for tabs is displayed as the extension actio
 ## Syntax
 
 ```js-nolint
-let count = browser.declarativeNetRequest.setExtensionActionOptions();
+let count = browser.declarativeNetRequest.setExtensionActionOptions(
+ extensionActionOptions, // object
+);
 ```
 
 ### Parameters

@@ -42,7 +42,7 @@ let result = await browser.declarativeNetRequest.testMatchOutcome(
  - `url`
  - : A `string`. The URL of the hypothetical request.
 
-- `options`
+- `options` {{optional_inline}}
 
  - : Details of options for the request.
  - `includeOtherExtensions` {{optional_inline}}

@@ -15,7 +15,7 @@ browser-compat: webextensions.api.declarativeNetRequest.updateDynamicRules
 
 {{AddonSidebar()}}
 
-Modifies the set of dynamic rules for the extension. The rules with IDs listed in options.removeRuleIds are first removed, and then the rules given in options.addRules are added. Note that:
+Modifies the set of dynamic rules for the extension. The rules with IDs listed in `options.removeRuleIds` are first removed, and then the rules given in `options.addRules` are added. Note that:
 
 - This update happens as an atomic operation: either all specified rules are added and removed, or an error is returned.
 - These rules are persisted across browser sessions and across extension updates.

@@ -52,7 +52,7 @@ These are the `manifest.json` keys; these keys are available in Manifest V2 and
 - [optional_permissions](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_permissions)
 - [options_page](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_page)
 - [options_ui](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_ui)
-- [page_action](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/page_action) (Manifest V2 only)
+- [page_action](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/page_action) (Manifest V2 only in Chrome)
 - [permissions](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions)
 - [protocol_handlers](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/protocol_handlers)
 - [short_name](/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/short_name)