Document font-palette & @font-palette-values with its descriptors #22519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…descriptor on each page
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
dipikabh
requested changes
Dec 6, 2022
There was a problem hiding this comment.
Thank you, @dletorey for answering my comments. Please go ahead and update the text as you've suggested.
Also for now, you can ignore my comments about adding more descriptions to Examples and Result sections. Let's do that in a new PR after this one lands.
files/en-us/web/css/@font-palette-values/override-colors/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Dec 8, 2022
* upstream/main: (286 commits) Correct Epsilon property description (mdn#22804) Fix typo in subtle crypto digest (mdn#22802) Alt tag added - reference issue mdn#21616 (mdn#22255) WeakSet: Improve recursive validation example (mdn#22787) New page: validityState.valueMissing (mdn#22691) Edit: <dialog> element (mdn#22786) Update Paint Timing pages (mdn#22771) chore(deps): bump @mdn/yari from 1.27.16 to 1.27.20 (mdn#22791) chore(deps): bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (mdn#22790) Remove WebGLSidebar (mdn#22782) fix indefinite articles usage (mdn#22789) Removed part of sentence that refers to code that appears to have been removed (mdn#22788) Split (Async)?(Generator)?Function class and ctor pages (mdn#22778) Fix interfaces links (mdn#22779) Change "hypertext link" to "hypertext links" (mdn#22780) add hyphenate-limit-chars CSS property (mdn#22747) 22225: Add links to accessibility guides section (mdn#22240) ci(markdownlint): use GitHub API to get changed files (mdn#22773) Document font-palette & @font-palette-values with its descriptors (mdn#22519) fix typo in createImageBitmap api (mdn#22774) ...
hamishwillee
pushed a commit
to hamishwillee/content
that referenced
this pull request
Dec 12, 2022
…n#22519) * created the pages needed with default content * added more tags * added first draft of the font-palette page * added the first draft of font-palette-values page * created the dashed-ident paged and referenced it to/from ident and custom-ident * fixed explanations and missing punctuation * updated the @rules to be consistent with At-rules * americanized the spelling an dmade @rules consistent * updated all links to be markdown links * updated the bcd location * added content for font-family & override-colors descriptors * updated the font-family descriptor with grammar issues * added images to base-palette and override-colors and descriptions * completed the override-colors descriptor and added references to css descriptor on each page * added the COLRv1 color-font new features to the release notes * fixed the broken link in the content * Update files/en-us/mozilla/firefox/releases/107/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/font-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/font-family/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/base-palette/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/override-colors/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/override-colors/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/override-colors/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/override-colors/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/@font-palette-values/override-colors/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/css/dashed-ident/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * added a description of the dark palette example mdn#22519 * updated the introductory sentence about @font-palette-values mdn#22519 * updated the description of the override-colors descriptor mdn#22519 * added a description of the override-colors example mdn#22519 * added explanation of why base-palette is not always needed mdn#22519 * updated the name of the example mdn#22519 * rewritten the explanation of using the same identifier for multiple fonts mdn#22519 * rewritten the explanation of the use of the font-family name mdn#22519 * updated the name of the liveSample mdn#22519 * updated the example name mdn#22519 * updated the description of the changing default palette example mdn#22519 * added spacing to the syntax example mdn#22519 * rewqritten the explanation about color and base-palette indexes mdn#22519 * removed the example headings * added a difference between custom and dashed idents mdn#22519 * added a note that there is no bcd for these types mdn#22519 * Update files/en-us/mozilla/firefox/releases/107/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> Co-authored-by: Dipika Bhattacharya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on the [CSS] Ship COLRv1 color-font support #21537 I have created pages for:
Motivation
Completing documentation for the Firefox release of COLRv1 color-font support
Additional details
Related issues and pull requests
Relates to #21537