Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects code snippet on background scripts page #20006

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Corrects code snippet on background scripts page #20006

merged 2 commits into from
Aug 26, 2022

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Aug 26, 2022

Summary

Makes the Filter events code example more generic, by replacing alert with console.log.

Related issues

Fixes #18936

Metadata

This PR…

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@rebloor rebloor added the Content:WebExt WebExtensions docs label Aug 26, 2022
@rebloor rebloor requested a review from rpl August 26, 2022 17:46
@rebloor rebloor self-assigned this Aug 26, 2022
@rebloor rebloor requested a review from a team as a code owner August 26, 2022 17:46
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Aug 26, 2022
teoli2003
teoli2003 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Background_scripts
Title: Background scripts
on GitHub

No new external URLs

@teoli2003 teoli2003 merged commit 4d5448b into mdn:main Aug 26, 2022
@rebloor rebloor deleted the 18936-Background-scripts-page-snippet-correction branch September 1, 2022 00:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@rpl rpl Awaiting requested review from rpl

Assignees

@rebloor rebloor

Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Background scripts: Snippet requires correction
2 participants
@rebloor @teoli2003