Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentFragment: Use more modern append() #18845

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

tomayac
Copy link
Contributor

@tomayac tomayac commented Jul 27, 2022

Summary

Modernize code sample.

Motivation

Smaller code.

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@tomayac tomayac requested a review from a team as a code owner July 27, 2022 09:16
@tomayac tomayac requested review from jpmedley and removed request for a team July 27, 2022 09:16
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Preview URLs

Flaws

URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/DocumentFragment/getElementById does not exist

External URLs

URL: /en-US/docs/Web/API/DocumentFragment
Title: DocumentFragment
on GitHub

No new external URLs

(this comment was updated 2022-07-27 09:32:40.081205)

@tomayac
Copy link
Contributor Author

tomayac commented Jul 27, 2022

At least in the staging preview all the links below seem to 404:

  • {{domxref("Node.appendChild", "appendChild()")}}
  • {{domxref("Element.append", "append()")}}
  • {{domxref("Node.insertBefore", "insertBefore()")}}

@teoli2003
Copy link
Member

At least in the staging preview all the links below seem to 404:

* `{{domxref("Node.appendChild", "appendChild()")}}`

* `{{domxref("Element.append", "append()")}}`

* `{{domxref("Node.insertBefore", "insertBefore()")}}`

This is normal, they are not generated in the prXYZ.developer.mozilla.org domain as they weren't changed.

Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@teoli2003 teoli2003 merged commit 8d0869b into mdn:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants