Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification regarding the use of SVG in NotificationOptions #18239

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Clarification regarding the use of SVG in NotificationOptions #18239

merged 4 commits into from
Jul 29, 2022

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Jul 11, 2022

Summary

Adds note that when using an SVG image in NotificationOptions ensure that the image includes height and width directives. Provides content requested in Bug 1688492.

Metadata

This PR…

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@rebloor rebloor added the Content:WebExt WebExtensions docs label Jul 11, 2022
@rebloor rebloor requested a review from a team as a code owner July 11, 2022 23:09
@rebloor rebloor self-assigned this Jul 11, 2022
@rebloor rebloor requested review from willdurand and removed request for a team July 11, 2022 23:09
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Jul 11, 2022
Rob--W
Rob--W approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a suggested edit to rename "directives" to "attributes", and a concrete value instead of "something" (96), plus a weakened version of the statement ("does not" -> "may not"). Feel free to copy-edit as you see fit before merging.

files/en-us/mozilla/add-ons/webextensions/api/notifications/notificationoptions/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/notifications/notificationoptions/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022 •
edited

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/notifications/NotificationOptions
Title: notifications.NotificationOptions
on GitHub

No new external URLs

(this comment was updated 2022-07-29 02:25:26.608605)

@rebloor rebloor merged commit 26ffa17 into mdn:main Jul 29, 2022
@rebloor rebloor deleted the svg-in-NotificationOptions-clarrification branch July 29, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdurand willdurand willdurand approved these changes

@Rob--W Rob--W Rob--W approved these changes

Assignees

@rebloor rebloor

Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rebloor @willdurand @Rob--W