serviceWorkers and indexedDB delete by hostname #17865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2022-07-12 18:33:17.744428) |
evilpie
reviewed
Jul 2, 2022
| @@ -30,9 +30,9 @@ Values of this type are objects. They contain the following properties: | |||
|
|
|||
| - `hostnames` {{optional_inline}} | |||
|
|
|||
| - : `Array` of `string`. This property only applies to cookies and local storage items. Only remove cookies and local storage items which are associated with these hostnames. | |||
| - : `Array` of `string`. This property applies to cookies, indexedDB, local storage, and service worker items. Remove only cookies, indexedDB, local storage, and service worker items associated with these hostnames. | |||
There was a problem hiding this comment.
Maybe these should be links? I think we would usually write "ServiceWorker".
There was a problem hiding this comment.
Maybe these should be links?
Do you mean, for example:
- service worker > Using Service Workers
- indexedDB > Using IndexedDB
I'm not sure either document makes it obvious what's been deleted, any thoughts on better links?
I think we would usually write "ServiceWorker".
When describing the ServiceWorker interface we use the phrase "reference to a service worker". So I believe this is correct for a generic reference.
Rob--W
approved these changes
Jul 12, 2022
| @@ -30,9 +30,9 @@ Values of this type are objects. They contain the following properties: | |||
|
|
|||
| - `hostnames` {{optional_inline}} | |||
|
|
|||
| - : `Array` of `string`. This property only applies to cookies and local storage items. Only remove cookies and local storage items which are associated with these hostnames. | |||
| - : `Array` of `string`. This property applies to cookies, indexedDB, local storage, and service worker items. Remove only cookies, indexedDB, local storage, and service worker items associated with these hostnames. | |||
There was a problem hiding this comment.
"service worker items" -> "service worker registrations"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds details about the deletion of serviceWorkers and indexedDB by hostname in browsingData. Provides the content for:
(Release note changes were previously made in
content/files/en-us/mozilla/firefox/releases/77/index.md
Line 61 in 94e0453
Related BCD changes provided in mdn/browser-compat-data#16838
Metadata
This PR…