Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WritableStream()] underlyingSink is optional #1424

Merged
merged 1 commit into from
Jan 18, 2021
Merged

[WritableStream()] underlyingSink is optional #1424

merged 1 commit into from
Jan 18, 2021

Conversation

tomayac
Copy link
Contributor

@tomayac tomayac commented Jan 18, 2021

See spec.

@tomayac tomayac requested a review from a team as a code owner January 18, 2021 10:23
@tomayac tomayac requested review from Rumyra and removed request for a team January 18, 2021 10:23
chrisdavidmills
chrisdavidmills approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And again, LGTM!

@chrisdavidmills chrisdavidmills merged commit 44b8aa8 into mdn:main Jan 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomayac @chrisdavidmills