Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in HTTP Cookies, "Updating cookies via JavaScript" Section #34121

Closed
At11011 opened this issue Jun 13, 2024 · 4 comments · Fixed by #34131
Closed

Typo in HTTP Cookies, "Updating cookies via JavaScript" Section #34121

At11011 opened this issue Jun 13, 2024 · 4 comments · Fixed by #34131
Labels
Content:HTTP HTTP docs good first issue A good issue for newcomers to get started with.

Comments

@At11011
Copy link
Contributor

At11011 commented Jun 13, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies

What specific section or headline is this issue about?

Updating cookies via JavaScript

What information was incorrect, unhelpful, or incomplete?

There is a small typo in this section:

You can also access existing cookies and set new values for them, provided the [HttpOnly](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#httponly) attribute isn't set on them (i.e. in the Set-Cookie header than created it):

This is the typo:

(i.e. in the Set-Cookie header ___than___ created it)

What did you expect to see?

In this text:

"(i.e. in the Set-Cookie header than created it)"

"than" should be replaced with "that".

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@At11011 At11011 added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 13, 2024
@github-actions github-actions bot added the Content:HTTP HTTP docs label Jun 13, 2024
@Josh-Cena Josh-Cena added good first issue A good issue for newcomers to get started with. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 13, 2024
@bsmth
Copy link
Member

bsmth commented Jun 13, 2024

Thanks for raising this one. Would you like to open a PR to fix it?

@At11011
Copy link
Contributor Author

At11011 commented Jun 13, 2024

Thanks for raising this one. Would you like to open a PR to fix it?

Sure thing, I opened one here:
#34131

Thanks!

@At11011 At11011 closed this as completed Jun 13, 2024
@Josh-Cena Josh-Cena mentioned this issue Jun 13, 2024
Merged
@Josh-Cena
Copy link
Member

@At11011 FYI, the usual workflow is this: you open an issue -> you send a PR -> in the PR description, you say "fixes #34121" -> when that PR gets merged, this issue will be automatically closed. You only close the issue when the issue is actually fixed, not when the PR is still open.

@At11011
Copy link
Contributor Author

At11011 commented Jun 13, 2024

@At11011 FYI, the usual workflow is this: you open an issue -> you send a PR -> in the PR description, you say "fixes #34121" -> when that PR gets merged, this issue will be automatically closed. You only close the issue when the issue is actually fixed, not when the PR is still open.

Thank you, I'll do that next time.

That was actually my first pull request to a large public repo, I appreciate your guidence and promptness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content:HTTP HTTP docs good first issue A good issue for newcomers to get started with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed typo in HTTP Cookies At11011/content
3 participants
@bsmth @Josh-Cena @At11011