Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate description of metrics retrieval from first available font in font-size-adjust #29339

Closed
drott opened this issue Sep 28, 2023 · 1 comment · Fixed by #29364
Closed

Inaccurate description of metrics retrieval from first available font in font-size-adjust #29339

drott opened this issue Sep 28, 2023 · 1 comment · Fixed by #29364
Labels
Content:CSS Cascading Style Sheets docs help wanted If you know something about this topic, we would love your help!

Comments

@drott
Copy link

drott commented Sep 28, 2023

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/font-size-adjust

What specific section or headline is this issue about?

Description of usage of first available font.

What information was incorrect, unhelpful, or incomplete?

Uses the value for the specified from the first available font that is able to provide the desired metric.

This sentence is not accurate. from-font uses the value from the first available font, whether it has the value or not. If it does not, a value is likely synthesized.

What did you expect to see?

Strip the last part of the sentence.

Do you have any supporting links, references, or citations?

See also w3c/csswg-drafts#6384

https://drafts.csswg.org/css-fonts-5/#font-size-adjust-prop:~:text=Computes%20to%20the%20%3Cnumber%3E%20corresponding%20to%20the%20specified

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@drott drott added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Sep 28, 2023
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 28, 2023
@OnkarRuikar
Copy link
Contributor

The discussion w3c/csswg-drafts#6384 hasn't concluded yet. But it makes sense to keep the value consistent with the first available font.

OnkarRuikar added a commit to OnkarRuikar/content that referenced this issue Sep 29, 2023
@OnkarRuikar
fix(css): Update font-size-adjust: from-font description
8b0bc66 
- fixes mdn#29339
@OnkarRuikar OnkarRuikar mentioned this issue Sep 29, 2023
Merged
@Josh-Cena Josh-Cena added help wanted If you know something about this topic, we would love your help! and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 30, 2023
estelle pushed a commit that referenced this issue Oct 2, 2023
@OnkarRuikar
fix(css): Update font-size-adjust: from-font description (#29364)
8fc53f0 
- fixes #29339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs help wanted If you know something about this topic, we would love your help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(css): Update font-size-adjust: from-font description OnkarRuikar/content
3 participants
@drott @Josh-Cena @OnkarRuikar