Fix clang-format-diff usage #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"--style" is invalid:
$ ./checkpatch.sh -r HEAD
usage: clang-format-diff [-h] [-i] [-p NUM] [-regex PATTERN] [-iregex PATTERN]
[-sort-includes] [-v] [-style STYLE] [-binary BINARY]
clang-format-diff: error: unrecognized arguments: --style={ Language:... }
06acbf8
to
866fbb5
Compare
azat
reviewed
May 27, 2020
| @@ -164,8 +164,8 @@ function clang_style() | |||
| local c="${options[cfg]}" | |||
| echo "{ $(sed -e 's/#.*//' -e '/---/d' -e '/\.\.\./d' "$c" | tr $'\n' ,) }" | |||
| } | |||
| function clang_format() { clang-format --style="$(clang_style)" "$@"; } | |||
| function clang_format_diff() { clang-format-diff --style="$(clang_style)" "$@"; } | |||
| function clang_format() { clang-format -style="$(clang_style)" "$@"; } | |||
There was a problem hiding this comment.
but clang-format has --style, although works both, ok
There was a problem hiding this comment.
Oh sorry, I overlooked...
Please feel free to revert this line.
Thanks for reviewing.
azat
added a commit
that referenced
this pull request
May 27, 2020
azat
added a commit
that referenced
this pull request
May 27, 2020
- strip 1 path component - it does not accept file name anymore, only stdin Refs: #1029
azat
added a commit
to azat/libevent
that referenced
this pull request
Jun 28, 2020
Refs: libevent#1029 (cherry picked from commit 8209a62)
azat
added a commit
to azat/libevent
that referenced
this pull request
Jun 28, 2020
- strip 1 path component - it does not accept file name anymore, only stdin Refs: libevent#1029 (cherry picked from commit 89d313b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: