Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall.cmake.in is missing from 2.1.11 release #863

Closed
theirix opened this issue Aug 2, 2019 · 2 comments
Closed

Uninstall.cmake.in is missing from 2.1.11 release #863

theirix opened this issue Aug 2, 2019 · 2 comments
Labels
build

Comments

@theirix
Copy link

theirix commented Aug 2, 2019

Trying to build a fresh 2.1.11 release. It introduces generating Uninstall.cmake but the source file cmake/Uninstall.cmake.in is missing from the official archive so build fails. Release notes said to use libevent-2.1.11-stable.tar.gz (not the sources generated by github automatically).

Reproducing (on macOS):

cmake -DEVENT__DISABLE_OPENSSL=True .
...
CMake Error: File /Users/irix/Downloads/libevent-2.1.11-stable/cmake/Uninstall.cmake.in does not exist.
CMake Error at CMakeLists.txt:1498 (configure_file):
  configure_file Problem configuring file
@azat azat closed this as completed in f05ba67 Aug 3, 2019
@azat
Copy link
Member

azat commented Aug 3, 2019

Thanks for the report!

Fixed in upstream, but it will not be fixed in dist archive, since it had been released already

Release notes said to use libevent-2.1.11-stable.tar.gz (not the sources generated by github automatically).

Well let's me elaborate this a little, libevent's cmake support is in beta stage for now, so it is recommended to use autotools build, and this dist archive is only related to autotools, IOW it is perfectly fine to use sources generated by github if you are using cmake.

@azat azat added the build label Aug 3, 2019
@theirix
Copy link
Author

theirix commented Aug 4, 2019

Thanks for the quick fix!

Sure, I was aware of experimental support for CMake for previous versions of libevent but I thought CMake became an official build method since 2.1.10 when it was reflected in documentation (Building.md).

This was referenced Aug 8, 2019
Closed
Closed
@ygj6 ygj6 mentioned this issue Aug 10, 2019
Closed
@azat azat mentioned this issue Aug 13, 2019
Closed
azat added a commit to azat/libevent that referenced this issue Jun 28, 2020
@azat
Add Uninstall.cmake.in into dist archive
877f235 
Fixes: libevent#863
(cherry picked from commit f05ba67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azat @theirix