Mobile: Describe the plugin settings page #10207 #10511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We chose not to proceed with the functionality topic related to GitHub mirror because during our analysis of the code in the mobile app, we did not fully comprehend how integrating with GitHub mirror would be beneficial for the project. We tried to fully understand how GitHub mirror works and how it could be integrated into our project, but we concluded that the part of the code related to plugins did not seem suitable for using this functionality. As we were unable to clearly discern the objective or the benefits that GitHub mirror would bring in this specific context, we decided to direct our efforts to areas of the project where we could have a more immediate and understandable impact. We focused on the area of plugin categories. First and foremost, it's important to note that a single plugin can belong to more than one category. However, upon reviewing the plugins page, we found that the immediate information available (without clicking on each plugin's description) seemed insufficient in terms of providing comprehensive details about the categories each plugin falls into. Therefore, the first functionality we implemented was on the plugin search page, displaying one of the categories to which each plugin belonged. If a plugin belonged to more than one category, we showed the symbol "+" as there wasn't enough space to list them all. Each plugin box had to remain concise, and we didn't want to completely change the developers' project implementation. Additionally, if a plugin didn't belong to any specific category, we added "Other" to indicate its classification. We also added a plugin search filter by category, and on each specific plugin page, we included all of its categories. Co-authored-by: Rafael Ribeiro <[email protected]>
|
Thank you for working on this! I'm adding a link to #10207 to make it easier to find this PR from the issue. A few comments:
|
|
Thank you for your feedback @personalizedrefrigerator ! To avoid the merge conflicts you mentioned due to the ongoing redesign of the settings page in Mobile, we will shift our focus towards creating the new filter as proposed. We appreciate the suggestion and will work on implementing the filter by category within a search filters dialog. This approach should help in making the categories more apparent. Thank you for the example provided. We'll also post an explanation of the design and gather community feedback on the Forum to ensure the changes are well-aligned with user expectations. Thank you for your guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We chose not to proceed with the functionality topic related to GitHub
mirror because during our analysis of the code in the mobile app, we
did not fully comprehend how integrating with GitHub mirror would be
beneficial for the project.
We tried to fully understand how GitHub
mirror works and how it could be integrated into our project, but we
concluded that the part of the code related to plugins did not seem
suitable for using this functionality.
As we were unable to clearly
discern the objective or the benefits that GitHub mirror would bring
in this specific context, we decided to direct our efforts to areas of
the project where we could have a more immediate and understandable impact.
We focused on the area of plugin categories. First and foremost, it's important to note that a single plugin can belong to more than one category. However, upon reviewing the plugins page, we found that the immediate information available (without clicking on each plugin's description) seemed insufficient in terms of providing comprehensive details about the categories each plugin falls into. Therefore, the first functionality we implemented was on the plugin search page, displaying one of the categories to which each plugin belonged. If a plugin belonged to more than one category, we showed the symbol "+" as there wasn't enough space to list them all.
Additionally, if a plugin didn't belong to any specific category, we added "Other" to indicate its classification.
We also added a plugin search filter by category, and on each specific plugin page, we included all of its categories.
Here are some screenshots demonstrating what we implemented:
Plugin box:
Filtered by... :
Filtered by "productivity" example: