-
Notifications
You must be signed in to change notification settings - Fork 40.9k
add validation logic for APIVersion fields of HPA #132537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @lalitc375. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @cici37 |
/ok-to-test |
c771ca3
to
00d0717
Compare
/retest |
00d0717
to
831f360
Compare
831f360
to
448bf88
Compare
448bf88
to
77cc677
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lalitc375 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New validation logic follows the API ratcheting principle, will not be executed for already stored invalid if the corresponding fields or item in array is not modified. Please enter the commit message for your changes. Lines starting
77cc677
to
1fdac6a
Compare
@lalitc375: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
New validation logic follows the API ratcheting principle, will not be executed for already stored invalid if the corresponding fields or item in array is not modified.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This adds validation logic on APIVersion fields of HorizontalPodAutoscaler type. There are no validation on this field, Invalid API version can result in non functioning HPA.
This also adds additional checks for ScaleTargetRef field, to make sure it is not empty when Kind is not replicationController.
Which issue(s) this PR is related to:
Fixes #60511
Special notes for your reviewer:
Does this PR introduce a user-facing change?