Skip to content

Missing validation in HPA #60511

New issue
New issue
Open
#132537
Open
Missing validation in HPA#60511
#132537
Assignees
lalitc375
Labels
kind/bugCategorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.sig/autoscalingCategorizes an issue or PR as relevant to SIG Autoscaling.
@MaciekPytel

Description

@MaciekPytel
MaciekPytel
opened on Feb 27, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
It looks like validation of HPA is insufficient:

  • metric name in pods and object metrics should be checked using IsValidPathSegmentName as they're used as part of request to custom metrics API (this is analogous to Validate path in external metric name #60433).
  • ValidateCrossVersionObjectReference allows for empty apiVersion, leading to non-functional HPA.

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.sig/autoscalingCategorizes an issue or PR as relevant to SIG Autoscaling.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions